Perfdata errors #116
Merged
Perfdata errors #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 17, 2024 14:28
This patch changes the function signature of Performance data formatting functions to return errors. This is a preparation step to allow the rejection of certain values, which are valid values for that data type, but not valid as measurements
|
closes #115 |
|
Nice. I'll have a look at it later today |
martialblog
reviewed
Jun 18, 2024
perfdata/type.go
Outdated
| // Returns an eror in some known cases where the value of a data type does not | ||
| // represent a valid measurement, see the explanation for "formatNumeric" for | ||
| // perfdata values. | ||
| func (p Perfdata) String() (string, error) { |
There was a problem hiding this comment.
I don't like that this is no longer implements the Stringer interface. https://pkg.go.dev/fmt#Stringer
I rather have the formatNumeric handle that and the Stringer interface be implemented, since it is more expectable when having a String() method on a struct.
Not sure how else we could or should communicate that NaN/Inf are not printed. Maybe just docs?
There was a problem hiding this comment.
I see your point. I think I have an idea.
There was a problem hiding this comment.
I restored the behaviour of String by using the new functionality and just ignoring errors.
There was a problem hiding this comment.
Coolio. I'll have a look later.
This commit restores the previous signature of String() for perfdata by moving the functionality in a new method (which is also exported). This new method validates the data and throws errors, the String() method catches them and just returns the empty string then.
martialblog
approved these changes
Jun 20, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.