Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloudfront url to amplify settings #399

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

GracefulLemming
Copy link
Contributor

@GracefulLemming GracefulLemming commented Jan 30, 2024

@LN7-cyber & @CharlieMcVicker:
This resolves the issue discussed in today's meeting.

@CharlieMcVicker: Important With the current code, amplify will have a url in the format xxxxxxxxxxxxx.cloudflare.net/ and not https://xxxxxxxxxxxxx.cloudflare.net/. I can change this for simplicity though.

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for dailp canceled.

Name Link
🔨 Latest commit fe8fd02
🔍 Latest deploy log https://app.netlify.com/sites/dailp/deploys/65b97383d5e3b0000829df2e

Copy link
Collaborator

@CharlieMcVicker CharlieMcVicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This format (without the protocol) is what the audio code expects to consume. Thanks so much!

@GracefulLemming GracefulLemming merged commit e3867ff into main Feb 1, 2024
5 checks passed
@GracefulLemming GracefulLemming deleted the add-cf-url-to-amplify-vars branch February 1, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants