Create-post-confirmation-lambda-event-handler #400
Conversation
✅ Deploy Preview for dailp canceled.
|
| .send() | ||
| .await | ||
| .map_err(|e| anyhow::Error::new(e)) | ||
| .map(|x| ()) |
There was a problem hiding this comment.
Does this line map the result to the empty tuple? I think I see the usecase here and if this is the standard pattern I'm fine with it. It just throws me a bit.
There was a problem hiding this comment.
it maps to rust's unit type, (), which "is used when there is no other meaningful value that could be returned" according to the type's documentation.
Why aren't we returning a more meaningful type here?
The AWS operation cognito:AdminAddUserToGroup returns an HTTP 200: Ok with an empty body when successful (docs). When unsuccessful, it returns one of the many Cognito API Errors, usually a variation of HTTP 400: Bad Request or 500: Internal Server Error.
Because a success is simply an OK but errors can be one of many things, the most important information for the main lambda operation is whether or not the operation succeeded, so returning the unit type seemed appropriate.
admin-event-handlers/src/auth/post-confirmation/google_sheets_operations.rs
Outdated
Show resolved
Hide resolved
| // First row is headers "Full Name" "Alt name" "DOB" "Role" "email" | ||
| for row in self.values.into_iter().skip(1) { |
There was a problem hiding this comment.
We could also assert this instead of skipping
There was a problem hiding this comment.
To clarify, do you mean using Macro std::assert here?
Share-spreadsheet-operations
GracefulLemming
deleted the
create-post-confirmation-lambda-event-handler
branch
Creates a new rust member for housing lambda event handlers that are not a core part of the application.
Creates a new rust binary with logic for a lambda that adds users to a group if their email is on a predefined list when they confirm their account.