-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24 add objective magnification factor #25
Conversation
b0ae4a2
to
2cf1552
Compare
uses the not yet imported data property http://purl.obolibrary.org/obo/OBI_0002815
Hi @Zack-83, I have added you two as term creators and updated the example as a TTL snippet the way it should be modeled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes in the example (within the TSV).
Co-authored-by: Giacomo Lanza <37865804+Zack-83@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now.
@Zack-83 I just noticed that in order to display the TSV as a table in GitHub, we cannot use tripple quotes but must use single quotes. See: https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/blob/StroemPhi-patch-1/src/templates/vibso_classes.tsv |
This PR closes #24 by adding the new class "objective magnification factor setting" within the TSV template and updating the component OWl generated from it.