Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 add objective magnification factor #25

Merged
merged 13 commits into from
Dec 22, 2022

Conversation

StroemPhi
Copy link
Member

@StroemPhi StroemPhi commented Dec 13, 2022

This PR closes #24 by adding the new class "objective magnification factor setting" within the TSV template and updating the component OWl generated from it.

@StroemPhi StroemPhi marked this pull request as draft December 13, 2022 11:55
@Zack-83 Zack-83 force-pushed the 24-add-objective-magnification-factor branch from b0ae4a2 to 2cf1552 Compare December 19, 2022 12:49
@Zack-83 Zack-83 marked this pull request as ready for review December 19, 2022 12:49
@StroemPhi StroemPhi marked this pull request as draft December 21, 2022 13:59
@StroemPhi
Copy link
Member Author

Hi @Zack-83, I have added you two as term creators and updated the example as a TTL snippet the way it should be modeled.
In your example suggestion you used this class incorrectly as the predicate (as data property) 😉
In the example, I took the shortcut of using the data property OBI:'has representation' attached to the instance of this kind of setting instead of using a OBI:value specification instance related to it via OBI:'has value specification'.
I hope this example is helpful for you

@StroemPhi StroemPhi marked this pull request as ready for review December 21, 2022 14:53
Copy link
Collaborator

@Zack-83 Zack-83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes in the example (within the TSV).

StroemPhi and others added 2 commits December 22, 2022 10:41
Co-authored-by: Giacomo Lanza <37865804+Zack-83@users.noreply.github.com>
Copy link
Member Author

@StroemPhi StroemPhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now.

@StroemPhi StroemPhi merged commit 908ce9b into main Dec 22, 2022
@StroemPhi StroemPhi deleted the 24-add-objective-magnification-factor branch December 22, 2022 10:18
@StroemPhi
Copy link
Member Author

@Zack-83 I just noticed that in order to display the TSV as a table in GitHub, we cannot use tripple quotes but must use single quotes. See: https://github.com/NFDI4Chem/VibrationalSpectroscopyOntology/blob/StroemPhi-patch-1/src/templates/vibso_classes.tsv

@Zack-83
Copy link
Collaborator

Zack-83 commented Jan 4, 2023

It is deadly difficult to correct a TSV table without forgetting a tab.

And the poor English knowledge of GitHub does not help :(

image

Just merge yours and then it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] add "objective magnification"
2 participants