Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme #22

Merged
merged 7 commits into from
Mar 13, 2024
Merged

updated readme #22

merged 7 commits into from
Mar 13, 2024

Conversation

pojith
Copy link
Contributor

@pojith pojith commented Mar 6, 2024

No description provided.

Copy link
Member

@cpauvert cpauvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pojith,
thanks for contributing to #20! I thought you wanted to start with #19 as you commented directly on this issue, and it is a good first issue for someone not familiar with the repository.
That being said, any help is appreciated, I made a couple of comments regarding your contribution here that would need to be addressed before merging your PR. Let me know if something needs to be further explained.
Best,

README.md Outdated Show resolved Hide resolved
README.md Outdated
<a rel="license" href="http://creativecommons.org/licenses/by/4.0/">Creative
Commons Attribution 4.0 International License</a>.
This work is licensed under a
Creative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creative

put on a single line

README.md Outdated
Commons Attribution 4.0 International License</a>.
This work is licensed under a
Creative
Commons Attribution 4.0 International License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Commons Attribution 4.0 International License.

put on a single line

README.md Outdated
@@ -703,9 +703,6 @@ Tatusova, et al. 2008. “The Minimum Information about a Genome Sequence
“GSC MIxS: Host-associatedMIMS.”
<https://genomicsstandardsconsortium.github.io/mixs/Host-associatedMIMS/>.

“GSC MIxS: Human-associatedMIMS.”
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why you removed this URL @pojith?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@pojith
Copy link
Contributor Author

pojith commented Mar 7, 2024

can you check now .

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
<br><br> This work is licensed under a
<a rel="license" href="http://creativecommons.org/licenses/by/4.0/">Creative
Commons Attribution 4.0 International License</a>.
+This work is licensed under a [Creative Commons Attribution 4.0 International License](http://creativecommons.org/licenses/by/4.0/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I removed the extra lines that must have slipped from a copy paste.

@cpauvert cpauvert merged commit 0f197d1 into NFDI4Microbiota:main Mar 13, 2024
@cpauvert
Copy link
Member

can you check now .

Thanks for your contribution @pojith. We will add our code of conduct #23 to state how we want to maintain a friendly collaborative environment, but as a rule of thumb for the future, using "please" or "thanks" never hurt ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants