Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle a reject in c:Phoenix.Socket.connect/3 #37

Merged
merged 4 commits into from
Jun 21, 2021
Merged

handle a reject in c:Phoenix.Socket.connect/3 #37

merged 4 commits into from
Jun 21, 2021

Conversation

the-mikedavis
Copy link
Collaborator

closes #36

totally missed this in testing 馃檭

@the-mikedavis the-mikedavis requested a review from a team June 21, 2021 14:13
@the-mikedavis the-mikedavis self-assigned this Jun 21, 2021
@the-mikedavis the-mikedavis mentioned this pull request Jun 21, 2021
Closed
tonyvanriet
tonyvanriet approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@tonyvanriet tonyvanriet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I blame code review

@the-mikedavis the-mikedavis merged commit 31fda03 into main Jun 21, 2021
@the-mikedavis the-mikedavis deleted the handle-rejection branch June 21, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyvanriet tonyvanriet tonyvanriet approved these changes

Assignees

@the-mikedavis the-mikedavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rejected connections are not handled
2 participants
@the-mikedavis @tonyvanriet