Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility with mint_web_socket v0.2.0 #46

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix compatibility with mint_web_socket v0.2.0 #46

merged 1 commit into from
Feb 17, 2022

Conversation

the-mikedavis
Copy link
Collaborator

This will likely be followed by a v0.9.0 release relying on Mint.WebSocket v1.0.0 when that gets published (if our internal testing goes well). The v0.2.0 tag has some breaking changes that need some changes by consumers.

@the-mikedavis the-mikedavis requested a review from a team February 17, 2022 15:57
@the-mikedavis the-mikedavis self-assigned this Feb 17, 2022
bjornrud
bjornrud approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@bjornrud bjornrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my ignorant dog approval. lgtm.

poodle intently listening and note taking

lib/slipstream/connection/impl.ex Show resolved Hide resolved
@the-mikedavis the-mikedavis merged commit 1932ed2 into main Feb 17, 2022
@the-mikedavis the-mikedavis deleted the md-mint-websocket-0.2.0 branch February 17, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornrud bjornrud bjornrud approved these changes

Assignees

@the-mikedavis the-mikedavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@the-mikedavis @bjornrud