Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current connection join_ref to phx_leave event #54

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

jesenko
Copy link
Contributor

@jesenko jesenko commented Apr 1, 2023

Phoenix 1.6.16 requires join_ref on phx_leave to match the one that established connection.

Behaviour in phoenix was changed in this commit:

phoenixframework/phoenix@0bbff98

Phoenix 1.6.16 requires `join_ref` on `phx_leave` to match the one that
established connection.

Behaviour in phoenix was changed in this commit:

phoenixframework/phoenix@0bbff98
Copy link
Collaborator

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@the-mikedavis the-mikedavis merged commit 46da058 into NFIBrokerage:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants