feat(module: action_sheet): update testing coverage (#515)

NG-ZORRO · Jul 30, 2019 · b74db68 · b74db68
1 parent 7f80c13
commit b74db68
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 54 deletions.
diff --git a/components/action-sheet/action-sheet-options.provider.ts b/components/action-sheet/action-sheet-options.provider.ts
@@ -11,6 +11,7 @@ export class ActionSheetOptions {
   className?: string;
   transitionName?: string = 'am-slide-up';
   maskTransitionName?: string = 'am-fade';
+  locale?;
 }
 
 @Injectable()
@@ -23,7 +24,6 @@ export class ShareOption {
 export class ShareActionSheetWithOptions extends ActionSheetOptions {
   options: ShareOption[] | ShareOption[][];
   cancelButtonText?: string = 'Cancel';
-  locale?;
 }
 
 @Injectable()

diff --git a/components/action-sheet/action-sheet-subject.service.ts b/components/action-sheet/action-sheet-subject.service.ts
diff --git a/components/action-sheet/action-sheet.component.spec.ts b/components/action-sheet/action-sheet.component.spec.ts
@@ -5,6 +5,7 @@ import { ActionSheetComponent } from './action-sheet.component';
 import { ActionSheet, ActionSheetModule, ButtonModule } from '../..';
 import { NgZorroAntdMobilePipesModule } from '../pipes/ng-zorro-antd-mobile.pipes.module';
 import { Overlay } from '@angular/cdk/overlay';
+import { en_US } from '../locale-provider/locale';
 describe('ActionSheetComponent', () => {
   let component: TestActionSheetBasicComponent;
   let fixture: ComponentFixture<TestActionSheetBasicComponent>;
@@ -73,6 +74,17 @@ describe('ActionSheetComponent', () => {
     flush();
     actionSheetEle = document.getElementsByTagName('actionsheet')[1];
     expect(actionSheetEle.querySelector('.am-action-sheet-share-list')).toBeTruthy('shareactionsheet is work');
+    actionSheetEle.querySelector('.am-action-sheet-share-list-item').click();
+    fixture.detectChanges();
+    flush();
+  }));
+
+  it('should shareActionSheet work', fakeAsync(() => {
+    component.dataList = [];
+    const button = buttons[1].nativeElement;
+    button.click();
+    fixture.detectChanges();
+    flush();
   }));
 
   it('should shareActionSheetMulpitleLine work', fakeAsync(() => {
@@ -131,6 +143,17 @@ export class TestActionSheetBasicComponent {
     icon: `<img src="https://gw.alipayobjects.com/zos/rmsportal/${obj.url}.png" style="width:36px"/>`,
     title: obj.title
   }));
+  dataList1 = [
+    { url: 'OpHiXAcYzmPQHcdlLFrc', title: '发送给朋友' },
+    { url: 'wvEzCMiDZjthhAOcwTOu', title: '新浪微博' },
+    { url: 'cTTayShKtEIdQVEMuiWt', title: '生活圈' },
+    { url: 'umnHwvEgSyQtXlZjNJTt', title: '微信好友' },
+    { url: 'SxpunpETIwdxNjcJamwB', title: 'QQ' }
+  ].map(obj => ({
+    icon: `<img src="https://gw.alipayobjects.com/zos/rmsportal/${obj.url}.png" style="width:36px"/>`,
+    title: obj.title
+  }));
+  locale = en_US;
 
   @ViewChild('message')
   message: ViewChild;
@@ -144,9 +167,10 @@ export class TestActionSheetBasicComponent {
         options: BUTTONS,
         cancelButtonIndex: BUTTONS.length - 1,
         destructiveButtonIndex: BUTTONS.length - 2,
-        title: 'action-title',
+        title: null,
         message: message,
-        maskClosable: true
+        maskClosable: true,
+        locale: this.locale
       },
       buttonIndex => {
         console.log(buttonIndex);
@@ -170,7 +194,7 @@ export class TestActionSheetBasicComponent {
   }
 
   showShareActionSheetMulpitleLine = () => {
-    const data = [[...this.dataList, this.dataList[2]], [this.dataList[3], this.dataList[4]]];
+    const data = [[...this.dataList1, this.dataList1[2]], [this.dataList1[3], this.dataList1[4]]];
     ActionSheet.showShareActionSheetWithOptions(
       {
         options: data,

diff --git a/components/action-sheet/action-sheet.component.ts b/components/action-sheet/action-sheet.component.ts
@@ -43,10 +43,7 @@ export class ActionSheetComponent implements OnInit, OnDestroy {
   }
 
   isTemplateRef(value) {
-    if (value) {
-      return value instanceof TemplateRef;
-    }
-    return false;
+    return value instanceof TemplateRef;
   }
 
   isArray(options: any, value: any) {

diff --git a/components/action-sheet/public-api.ts b/components/action-sheet/public-api.ts
@@ -1,5 +1,4 @@
 export { ActionSheetModule } from './action-sheet.module';
 export { ActionSheetComponent } from './action-sheet.component';
-export { ActionSheetSubjectService } from './action-sheet-subject.service';
 export { ActionSheetService, ActionSheetService as ActionSheet } from './action-sheet.service';
 export { ActionSheetOptions, ShareOption, ShareActionSheetWithOptions, ActionSheetWithOptions, ActionCallBack } from './action-sheet-options.provider';