Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: action_sheet): update testing coverage #515

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #515 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #515      +/-   ##
=========================================
+ Coverage   88.58%   88.8%   +0.22%     
=========================================
  Files         269     268       -1     
  Lines        7514    7493      -21     
  Branches     1064    1058       -6     
=========================================
- Hits         6656    6654       -2     
+ Misses        433     417      -16     
+ Partials      425     422       -3
Impacted Files Coverage Δ
...ents/action-sheet/action-sheet-options.provider.ts 100% <ø> (ø) ⬆️
components/action-sheet/public-api.ts 100% <ø> (ø) ⬆️
components/action-sheet/action-sheet.component.ts 97.05% <100%> (+16.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f80c13...aca0786. Read the comment docs.

@fisherspy fisherspy merged commit b74db68 into NG-ZORRO:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants