Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for danish locale #114

Closed
michaelkrog opened this issue Nov 19, 2018 · 5 comments
Closed

Add support for danish locale #114

michaelkrog opened this issue Nov 19, 2018 · 5 comments
Assignees

Comments

@michaelkrog
Copy link
Contributor

What problem does this feature solve?

The lack of danish language in the components.

What does the proposed API look like?

I expect the API to be consistent with implementation of other locales.

@fisherspy fisherspy self-assigned this Nov 19, 2018
@fisherspy
Copy link
Collaborator

Hi, @michaelkrog , currently there is a narrow vocabulary in nine components locale files, so it is easy to add a new language locale. However, none of us know danish, Would you like to create a PR?

@michaelkrog
Copy link
Contributor Author

michaelkrog commented Nov 19, 2018

Gladly @fisherspy.

However, as I understand the codebase, it needs to be added to ant-design-mobile first, right?
I created a PR for Danish in that here: ant-design/ant-design-mobile#2962

Awaiting it to be merged in.

EDIT
Okay. I see now that I may have misunderstood the dependency on ant-design-mobile. I'll give it another try.

@fisherspy
Copy link
Collaborator

fisherspy commented Nov 20, 2018

@michaelkrog you don't need to add it to ant-design-mobile, it's a react implementation. you just need to create a PR here. But the react team would be happy to accept your PR.

@fisherspy
Copy link
Collaborator

#115

@fisherspy
Copy link
Collaborator

@michaelkrog 0.9.9 is out, Danish is now supported, thanks to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants