Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2961. Adds danish locale #2962

Closed
wants to merge 1 commit into from
Closed

Fixes #2961. Adds danish locale #2962

wants to merge 1 commit into from

Conversation

michaelkrog
Copy link

@michaelkrog michaelkrog commented Nov 19, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@michaelkrog michaelkrog changed the title Adds danish locale Fixes #2961. Adds danish locale Nov 19, 2018
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@d3cbd31). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2962   +/-   ##
=========================================
  Coverage          ?   58.99%           
=========================================
  Files             ?       99           
  Lines             ?     2241           
  Branches          ?      640           
=========================================
  Hits              ?     1322           
  Misses            ?      913           
  Partials          ?        6
Flag Coverage Δ
#web 58.99% <0%> (?)
Impacted Files Coverage Δ
components/locale-provider/da_DK.tsx 0% <0%> (ø)
components/pull-to-refresh/locale/da_DK.tsx 0% <0%> (ø)
components/input-item/locale/da_DK.tsx 0% <0%> (ø)
components/menu/locale/da_DK.tsx 0% <0%> (ø)
components/pagination/locale/da_DK.tsx 0% <0%> (ø)
components/picker/locale/da_DK.tsx 0% <0%> (ø)
components/search-bar/locale/da_DK.tsx 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3cbd31...b6351da. Read the comment docs.

Picker,
SearchBar,
Menu,
PullToRefresh,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2s space as indent.

@doxiaodong doxiaodong mentioned this pull request Dec 18, 2018
1 task
@doxiaodong doxiaodong assigned likezero and zack24q and unassigned likezero Dec 19, 2018
@zack24q
Copy link
Contributor

zack24q commented Dec 27, 2018

@michaelkrog Please use 2s space as indent.

@zack24q
Copy link
Contributor

zack24q commented Jan 8, 2019

Close because no response

@zack24q zack24q closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants