Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: calendar): calendar add ngModel #164

Merged
merged 5 commits into from
Dec 13, 2018

Conversation

3fuyu
Copy link
Contributor

@3fuyu 3fuyu commented Dec 13, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #164 into master will decrease coverage by 0.11%.
The diff coverage is 68.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   86.59%   86.47%   -0.12%     
==========================================
  Files         221      221              
  Lines        7021     7071      +50     
  Branches      980      989       +9     
==========================================
+ Hits         6080     6115      +35     
- Misses        550      561      +11     
- Partials      391      395       +4
Impacted Files Coverage Δ
components/calendar/calendar.component.ts 70.47% <68.62%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b60cca...f405726. Read the comment docs.

@fisherspy fisherspy self-requested a review December 13, 2018 06:45
Copy link
Collaborator

@fisherspy fisherspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check the travis&codecoverage

@fisherspy fisherspy merged commit 327d33b into NG-ZORRO:master Dec 13, 2018
@3fuyu 3fuyu deleted the 3fuyu-calendar-add-ngmodel branch December 17, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants