feat(module: popover): feat add customClass for customer #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 86.51% 86.52% +0.01%
==========================================
Files 221 221
Lines 6983 6985 +2
Branches 978 978
==========================================
+ Hits 6041 6044 +3
Misses 550 550
+ Partials 392 391 -1
Continue to review full report at Codecov.
|
|
className maybe better than customClass? |
3fuyu
reviewed
Dec 3, 2018
| @@ -20,6 +20,7 @@ Properties | Descrition | Type | Default | |||
| | mask | Whether to display the mask background layer | Boolean | false | | |||
| | overlay | Popup layer content | TemplateRef | - | | |||
| | onSelect | when an option is selected | (node: any, index?: number): void | - | | |||
| | className | Custom popover class | string | am-popover | | |||
There was a problem hiding this comment.
| className | Custom popover class, e.g. "am-popover-${your custom class}" | string | am-popover |
much better?
3fuyu
approved these changes
Dec 3, 2018
fisherspy
pushed a commit
that referenced
this pull request
Mar 10, 2020
* feat(module: popover): feat add customCls for customer * feat(module: popover): feat modify className for customer * docs(module:popover): update docs className descrpition (#120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information