Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: slider): slider add ngModel #202

Merged
merged 3 commits into from
Dec 27, 2018

Conversation

sWhite01111
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Dec 26, 2018

Codecov Report

Merging #202 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage    86.4%   86.46%   +0.06%     
==========================================
  Files         224      224              
  Lines        7185     7204      +19     
  Branches     1006     1008       +2     
==========================================
+ Hits         6208     6229      +21     
  Misses        573      573              
+ Partials      404      402       -2
Impacted Files Coverage Δ
...ents/slider/slider-steps/slider-steps.component.ts 92.18% <ø> (ø) ⬆️
...ts/slider/slider-handle/slider-handle.component.ts 89.2% <ø> (+0.63%) ⬆️
...ents/slider/slider-track/slider-track.component.ts 100% <ø> (ø) ⬆️
...ents/slider/slider-marks/slider-marks.component.ts 92.85% <ø> (+1.42%) ⬆️
components/slider/slider.module.ts 100% <ø> (ø) ⬆️
components/slider/slider.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395efcb...8c00303. Read the comment docs.

Copy link
Collaborator

@fisherspy fisherspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   private onChangeFn: (value: number) => void = () => {};

   private onTouchFn: (value: number) => void = () => {};

pls change this two statements into:


  private _ngModelOnChange: (value: number) => void = () => {};

  private _ngModelOnTouched: () => void = () => {};

@fisherspy fisherspy merged commit 3db39ae into NG-ZORRO:master Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants