Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module: actionsheet): perf actionsheet with cdk #228

Merged
merged 2 commits into from Jan 9, 2019

Conversation

Guoyuanqiang
Copy link
Member

@Guoyuanqiang Guoyuanqiang commented Jan 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #228 into master will decrease coverage by 0.03%.
The diff coverage is 88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   86.51%   86.47%   -0.04%     
==========================================
  Files         224      224              
  Lines        7303     7298       -5     
  Branches     1023     1024       +1     
==========================================
- Hits         6318     6311       -7     
- Misses        587      588       +1     
- Partials      398      399       +1
Impacted Files Coverage Δ
components/modal/modal.module.ts 100% <ø> (ø) ⬆️
components/action-sheet/action-sheet.component.ts 73.68% <100%> (-5.49%) ⬇️
...ents/action-sheet/action-sheet-options.provider.ts 100% <100%> (ø) ⬆️
components/action-sheet/action-sheet.service.ts 83.33% <82.35%> (-4.6%) ⬇️
...ponents/core/directive/touch-feedback.component.ts 58.33% <0%> (-8.34%) ⬇️
components/core/services/popup.service.ts 85.71% <0%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9dbc5a...f4f9da9. Read the comment docs.

@fisherspy fisherspy merged commit 9a9988a into NG-ZORRO:master Jan 9, 2019
@Guoyuanqiang Guoyuanqiang deleted the actionsheet branch January 9, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants