Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: picker): feat set disabled work #231

Merged
merged 2 commits into from
Jan 9, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #231 into master will increase coverage by 0.25%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   86.38%   86.64%   +0.25%     
==========================================
  Files         229      229              
  Lines        7331     7322       -9     
  Branches     1034     1031       -3     
==========================================
+ Hits         6333     6344      +11     
+ Misses        591      573      -18     
+ Partials      407      405       -2
Impacted Files Coverage Δ
components/picker/picker.service.ts 85% <ø> (+22.5%) ⬆️
components/picker/picker.component.ts 70.05% <33.33%> (+3.2%) ⬆️
components/picker/picker.directive.ts 93.42% <50%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39870da...aa35808. Read the comment docs.

@fisherspy fisherspy merged commit 02733b4 into NG-ZORRO:master Jan 9, 2019
@Guoyuanqiang Guoyuanqiang deleted the picker branch January 9, 2019 13:24
@Guoyuanqiang
Copy link
Member Author

close #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants