Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: carousel): fix set Carousel component selectedIndex invalid. #269

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

Guoyuanqiang
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #269 into master will decrease coverage by 0.12%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #269      +/-   ##
=========================================
- Coverage   86.62%   86.5%   -0.13%     
=========================================
  Files         229     229              
  Lines        7367    7374       +7     
  Branches     1053    1053              
=========================================
- Hits         6382    6379       -3     
- Misses        568     584      +16     
+ Partials      417     411       -6
Impacted Files Coverage Δ
components/carousel/carousel.component.ts 73.4% <81.81%> (-2.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a579a2...ae24899. Read the comment docs.

@fisherspy fisherspy merged commit 55ae6d2 into NG-ZORRO:master Jan 29, 2019
@Guoyuanqiang Guoyuanqiang deleted the carousel branch January 31, 2019 08:29
@Guoyuanqiang Guoyuanqiang restored the carousel branch January 31, 2019 08:29
@Guoyuanqiang Guoyuanqiang deleted the carousel branch January 31, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants