Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:popover): add provider for PopoverOptions #30

Merged
merged 2 commits into from
Oct 11, 2018
Merged

fix(module:popover): add provider for PopoverOptions #30

merged 2 commits into from
Oct 11, 2018

Conversation

Guoyuanqiang
Copy link
Member

fix(module:popover): add provider for PopoverOptions

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

fix(module:popover): add provider for PopoverOptions
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #30 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #30   +/-   ##
======================================
  Coverage    85.9%   85.9%           
======================================
  Files         209     209           
  Lines        6889    6889           
  Branches      977     977           
======================================
  Hits         5918    5918           
  Misses        559     559           
  Partials      412     412
Impacted Files Coverage Δ
components/popover/popover.directive.ts 84.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96bf9b8...31180de. Read the comment docs.

chore: add git hook to check commit messages
@Guoyuanqiang Guoyuanqiang merged commit 8f9e1d3 into NG-ZORRO:master Oct 11, 2018
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
* fix(module:popover): add provider for PopoverOptions

fix(module:popover): add provider for PopoverOptions

* chore: add git hook to check commit messages

chore: add git hook to check commit messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant