Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: carousel): fix carousel style error #357

Merged
merged 2 commits into from Mar 25, 2019

Conversation

SharpFu
Copy link
Contributor

@SharpFu SharpFu commented Mar 22, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

add 'left:0'
Issue Number: #356

What is the new behavior?

the carousel dot will center

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #357 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         229      229           
  Lines        6891     6891           
  Branches      564      564           
=======================================
  Hits         6173     6173           
  Misses        554      554           
  Partials      164      164

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 924bcc2...a80b4df. Read the comment docs.

@SharpFu SharpFu changed the title fix carousel style error [#frontend]fix carousel style error Mar 22, 2019
@SharpFu SharpFu changed the title [#frontend]fix carousel style error fix(module: carousel): fix carousel style error Mar 22, 2019
@SharpFu
Copy link
Contributor Author

SharpFu commented Mar 22, 2019

how to Merg success,could you help me

@Guoyuanqiang
Copy link
Member

close #356

@Guoyuanqiang Guoyuanqiang merged commit 3e5c14a into NG-ZORRO:master Mar 25, 2019
fisherspy pushed a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants