Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module: all): support Angular 8 #553

Merged
merged 5 commits into from
Sep 3, 2019
Merged

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #553 into master will decrease coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   88.76%   88.56%   -0.21%     
==========================================
  Files         270      270              
  Lines        7604     7602       -2     
  Branches     1082     1082              
==========================================
- Hits         6750     6733      -17     
- Misses        411      426      +15     
  Partials      443      443
Impacted Files Coverage Δ
components/image-picker/image-picker.component.ts 72.65% <ø> (ø) ⬆️
components/tab-bar/tab-bar-item.component.ts 100% <ø> (ø) ⬆️
...omponents/textarea-item/textarea-item.component.ts 97.61% <ø> (ø) ⬆️
components/search-bar/search-bar.component.ts 98.07% <ø> (ø) ⬆️
components/tabs/tabs.component.ts 88.31% <ø> (-0.15%) ⬇️
...onents/calendar/datepicker/datepicker.component.ts 80.64% <ø> (ø) ⬆️
components/calendar/calendar.component.ts 82.19% <ø> (ø) ⬆️
components/tabs/default-tab-bar.component.ts 83.06% <ø> (ø) ⬆️
components/date-picker/date-picker.component.ts 73.85% <ø> (ø) ⬆️
components/input-item/input-item.component.ts 93.68% <ø> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0739e2c...a122c29. Read the comment docs.

Copy link
Contributor

@BronzeCui BronzeCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@fisherspy fisherspy merged commit c2fd82d into NG-ZORRO:master Sep 3, 2019
fisherspy added a commit that referenced this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants