Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: List): fix typescript build error #565

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

fisherspy
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy fisherspy requested a review from 3fuyu September 5, 2019 08:30
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #565 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         270      270           
  Lines        7602     7602           
  Branches     1082     1082           
=======================================
  Hits         6733     6733           
  Misses        426      426           
  Partials      443      443
Impacted Files Coverage Δ
components/list/list.component.ts 84.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf12cd8...b40a158. Read the comment docs.

@fisherspy fisherspy merged commit 46e66f2 into NG-ZORRO:master Sep 5, 2019
@fisherspy
Copy link
Collaborator Author

#563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants