Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: picker): fix select bug when data is a function #586

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

BronzeCui
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

fix #336

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #586 into master will decrease coverage by 0.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
- Coverage    88.4%   88.39%   -0.02%     
==========================================
  Files         270      270              
  Lines        7597     7599       +2     
  Branches     1082     1083       +1     
==========================================
+ Hits         6716     6717       +1     
- Misses        434      435       +1     
  Partials      447      447
Impacted Files Coverage Δ
components/picker/picker.directive.ts 88.04% <25%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde3d82...2bdaaaa. Read the comment docs.

Copy link
Collaborator

@fisherspy fisherspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不用lodash能判断不

@fisherspy fisherspy merged commit 26a07d7 into NG-ZORRO:master Sep 17, 2019
@BronzeCui BronzeCui deleted the fix-branch branch September 17, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picker Component returns an incorrect value and selects an error message
2 participants