Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: date-picker): fix NAN bug when fast scroll #589

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

BronzeCui
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

fix #579

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #589 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   88.39%   88.38%   -0.02%     
==========================================
  Files         270      270              
  Lines        7599     7600       +1     
  Branches     1083     1084       +1     
==========================================
  Hits         6717     6717              
- Misses        435      436       +1     
  Partials      447      447
Impacted Files Coverage Δ
components/date-picker/date-picker.component.ts 73.7% <0%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26a07d7...35856a2. Read the comment docs.

@fisherspy fisherspy merged commit 3e63d20 into NG-ZORRO:master Sep 18, 2019
@DeMeng33
Copy link
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker在快速划动时获取时间为NAN
4 participants