Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pulltorefresh): fix element height #699

Merged
merged 1 commit into from May 21, 2020
Merged

fix(module:pulltorefresh): fix element height #699

merged 1 commit into from May 21, 2020

Conversation

nuonuoge
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@nuonuoge nuonuoge requested a review from fisherspy May 20, 2020 07:45
@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #699 into 1.x will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              1.x     #699   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files         270      270           
  Lines        7622     7622           
  Branches     1097     1097           
=======================================
  Hits         6753     6753           
  Misses        422      422           
  Partials      447      447           
Impacted Files Coverage Δ
...nents/pull-to-refresh/pull-to-refresh.component.ts 74.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ebc91c...4a9b489. Read the comment docs.

@fisherspy fisherspy merged commit eb9fd9c into NG-ZORRO:1.x May 21, 2020
@nuonuoge nuonuoge deleted the 1.x branch June 1, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants