Skip to content

Commit

Permalink
feat(module:time-picker,select,tree-select): support nzId (#6379)
Browse files Browse the repository at this point in the history
  • Loading branch information
cipchk committed Feb 26, 2021
1 parent 4d80873 commit 85d423d
Show file tree
Hide file tree
Showing 13 changed files with 20 additions and 3 deletions.
2 changes: 1 addition & 1 deletion components/date-picker/date-picker.component.ts
Expand Up @@ -73,7 +73,7 @@ export type NzDatePickerSizeType = 'large' | 'default' | 'small';
[suffixIcon]="nzSuffixIcon"
(openChange)="onOpenChange($event)"
(focusChange)="onFocusChange($event)"
[id]="nzId"
[nzId]="nzId"
>
<date-range-popup
[isRange]="isRange"
Expand Down
4 changes: 2 additions & 2 deletions components/date-picker/picker.component.ts
Expand Up @@ -59,7 +59,7 @@ import { PREFIX_CLASS } from './util';
<div *ngIf="!isRange" class="{{ prefixCls }}-input">
<input
#pickerInput
[attr.id]="id"
[attr.id]="nzId"
[class.ant-input-disabled]="disabled"
[disabled]="disabled"
[readOnly]="inputReadOnly"
Expand Down Expand Up @@ -178,7 +178,7 @@ export class NzPickerComponent implements OnInit, AfterViewInit, OnChanges, OnDe
@Input() dropdownClassName?: string;
@Input() suffixIcon?: string | TemplateRef<NzSafeAny>;
@Input() dir: Direction = 'ltr';
@Input() id: string | null = null;
@Input() nzId: string | null = null;

@Output() readonly focusChange = new EventEmitter<boolean>();
@Output() readonly valueChange = new EventEmitter<CandyDate | CandyDate[] | null>();
Expand Down
1 change: 1 addition & 0 deletions components/select/doc/index.en-US.md
Expand Up @@ -28,6 +28,7 @@ import { NzSelectModule } from 'ng-zorro-antd/select';

| Property | Description | Type | Default | Global Config |
| -------- | ----------- | ---- | ------- | ------- |
| `[nzId]` | input id attribute inside the component| `string` | - |
| `[ngModel]` | Current selected nz-option value, double binding. | `any \| any[]` | - |
| `[compareWith]` | Same as [SelectControlValueAccessor](https://angular.io/api/forms/SelectControlValueAccessor#caveat-option-selection) | `(o1: any, o2: any) => boolean` | `(o1: any, o2: any) => o1===o2` |
| `[nzAutoClearSearchValue]` | Whether the current search will be cleared on selecting an item. Only applies when `mode` is set to `multiple` or `tags`. | `boolean` | `true` |
Expand Down
1 change: 1 addition & 0 deletions components/select/doc/index.zh-CN.md
Expand Up @@ -29,6 +29,7 @@ import { NzSelectModule } from 'ng-zorro-antd/select';

| 参数 | 说明 | 类型 | 默认值 | 全局配置 |
| --- | --- | --- | --- | --- |
| `[nzId]` | 组件内部 input 的 id 值 | `string` | - |
| `[ngModel]` | 当前选中的 nz-option 的 nzValue 值,可双向绑定,当 `nzMode``multiple``tags` 时,ngModel 为数组 | `any \| any[]` | - |
| `[compareWith]` |[SelectControlValueAccessor](https://angular.io/api/forms/SelectControlValueAccessor#caveat-option-selection) 相同 | `(o1: any, o2: any) => boolean` | `(o1: any, o2: any) => o1===o2` |
| `[nzAutoClearSearchValue]` | 是否在选中项后清空搜索框,只在 `mode``multiple``tags` 时有效。 | `boolean` | `true` |
Expand Down
2 changes: 2 additions & 0 deletions components/select/select-search.component.ts
Expand Up @@ -27,6 +27,7 @@ import { COMPOSITION_BUFFER_MODE } from '@angular/forms';
template: `
<input
#inputElement
[attr.id]="nzId"
autocomplete="off"
class="ant-select-selection-search-input"
[ngModel]="value"
Expand All @@ -42,6 +43,7 @@ import { COMPOSITION_BUFFER_MODE } from '@angular/forms';
providers: [{ provide: COMPOSITION_BUFFER_MODE, useValue: false }]
})
export class NzSelectSearchComponent implements AfterViewInit, OnChanges {
@Input() nzId: string | null = null;
@Input() disabled = false;
@Input() mirrorSync = false;
@Input() showInput = true;
Expand Down
3 changes: 3 additions & 0 deletions components/select/select-top-control.component.ts
Expand Up @@ -37,6 +37,7 @@ import { NzSelectItemInterface, NzSelectModeType, NzSelectTopControlItemType } f
<ng-container [ngSwitch]="mode">
<ng-container *ngSwitchCase="'default'">
<nz-select-search
[nzId]="nzId"
[disabled]="disabled"
[value]="inputValue!"
[showInput]="showSearch"
Expand Down Expand Up @@ -73,6 +74,7 @@ import { NzSelectItemInterface, NzSelectModeType, NzSelectTopControlItemType } f
(delete)="onDeleteItem(item.contentTemplateOutletContext)"
></nz-select-item>
<nz-select-search
[nzId]="nzId"
[disabled]="disabled"
[value]="inputValue!"
[autofocus]="autofocus"
Expand All @@ -91,6 +93,7 @@ import { NzSelectItemInterface, NzSelectModeType, NzSelectTopControlItemType } f
}
})
export class NzSelectTopControlComponent implements OnChanges {
@Input() nzId: string | null = null;
@Input() showSearch = false;
@Input() placeHolder: string | TemplateRef<NzSafeAny> | null = null;
@Input() open = false;
Expand Down
2 changes: 2 additions & 0 deletions components/select/select.component.ts
Expand Up @@ -74,6 +74,7 @@ export type NzSelectSizeType = 'large' | 'default' | 'small';
<nz-select-top-control
cdkOverlayOrigin
#origin="cdkOverlayOrigin"
[nzId]="nzId"
[open]="nzOpen"
[disabled]="nzDisabled"
[mode]="nzMode"
Expand Down Expand Up @@ -172,6 +173,7 @@ export class NzSelectComponent implements ControlValueAccessor, OnInit, AfterVie
static ngAcceptInputType_nzDisabled: BooleanInput;
static ngAcceptInputType_nzOpen: BooleanInput;

@Input() nzId: string | null = null;
@Input() nzSize: NzSelectSizeType = 'default';
@Input() nzOptionHeightPx = 32;
@Input() nzOptionOverflowSize = 8;
Expand Down
1 change: 1 addition & 0 deletions components/time-picker/doc/index.en-US.md
Expand Up @@ -25,6 +25,7 @@ import { NzTimePickerModule } from 'ng-zorro-antd/time-picker';

| Property | Description | Type | Default | Global Config |
| -------- | ----------- | ---- | ------- | ------------- |
| `[nzId]` | input id attribute inside the component| `string` | - |
| `[ngModel]` | to set time | `Date` | - |
| `[nzAddOn]` | called from timepicker panel to render some addon to its bottom | `TemplateRef<void>` | - |
| `[nzAllowEmpty]` | allow clearing text | `boolean` | `true` ||
Expand Down
1 change: 1 addition & 0 deletions components/time-picker/doc/index.zh-CN.md
Expand Up @@ -26,6 +26,7 @@ import { NzTimePickerModule } from 'ng-zorro-antd/time-picker';

| 参数 | 说明 | 类型 | 默认值 | 全局配置 |
| --- | --- | --- | --- | --- |
| `[nzId]` | 组件内部 input 的 id 值 | `string` | - |
| `[ngModel]` | 当前时间 | `Date` | - |
| `[nzAddOn]` | 选择框底部显示自定义的内容 | `TemplateRef<void>` | - |
| `[nzAllowEmpty]` | 是否展示清除按钮 | `boolean` | `true` ||
Expand Down
2 changes: 2 additions & 0 deletions components/time-picker/time-picker.component.ts
Expand Up @@ -48,6 +48,7 @@ const NZ_CONFIG_MODULE_NAME: NzConfigKey = 'timePicker';
<div class="ant-picker-input">
<input
#inputElement
[attr.id]="nzId"
type="text"
[size]="inputSize"
[placeholder]="nzPlaceHolder || (i18nPlaceHolder$ | async)"
Expand Down Expand Up @@ -153,6 +154,7 @@ export class NzTimePickerComponent implements ControlValueAccessor, OnInit, Afte
dir: Direction = 'ltr';

@ViewChild('inputElement', { static: true }) inputRef!: ElementRef<HTMLInputElement>;
@Input() nzId: string | null = null;
@Input() nzSize: string | null = null;
@Input() @WithConfig() nzHourStep: number = 1;
@Input() @WithConfig() nzMinuteStep: number = 1;
Expand Down
1 change: 1 addition & 0 deletions components/tree-select/doc/index.en-US.md
Expand Up @@ -22,6 +22,7 @@ import { NzTreeSelectModule } from 'ng-zorro-antd/tree-select';

| Property | Description | Type | Default | Global Config |
| -------- | ----------- | ---- | ------- | ------------- |
| `[nzId]` | input id attribute inside the component| `string` | - |
| `[nzAllowClear]` | Whether allow clear | `boolean` | `false` |
| `[nzPlaceHolder]` | Placeholder of the select input | `string` | - |
| `[nzDisabled]` | Disabled or not | `boolean` | `false` |
Expand Down
1 change: 1 addition & 0 deletions components/tree-select/doc/index.zh-CN.md
Expand Up @@ -22,6 +22,7 @@ import { NzTreeSelectModule } from 'ng-zorro-antd/tree-select';

| 参数 | 说明 | 类型 | 默认值 | 全局配置 |
| --- | --- | --- | --- | --- |
| `[nzId]` | 组件内部 input 的 id 值 | `string` | - |
| `[nzAllowClear]` | 显示清除按钮 | `boolean` | `false` |
| `[nzPlaceHolder]` | 选择框默认文字 | `string` | - |
| `[nzDisabled]` | 禁用选择器 | `boolean` | `false` |
Expand Down
2 changes: 2 additions & 0 deletions components/tree-select/tree-select.component.ts
Expand Up @@ -154,6 +154,7 @@ const TREE_SELECT_DEFAULT_CLASS = 'ant-select-dropdown ant-select-tree-dropdown'
</ng-container>
<nz-select-search
[nzId]="nzId"
[showInput]="nzShowSearch"
(keydown)="onKeyDownInput($event)"
(isComposingChange)="isComposing = $event"
Expand Down Expand Up @@ -228,6 +229,7 @@ export class NzTreeSelectComponent extends NzTreeBase implements ControlValueAcc
static ngAcceptInputType_nzDefaultExpandAll: BooleanInput;
static ngAcceptInputType_nzCheckStrictly: BooleanInput;

@Input() nzId: string | null = null;
@Input() @InputBoolean() nzAllowClear: boolean = true;
@Input() @InputBoolean() nzShowExpand: boolean = true;
@Input() @InputBoolean() nzShowLine: boolean = false;
Expand Down

0 comments on commit 85d423d

Please sign in to comment.