Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transplanting TreeSelect, Transfer, Upload from antd? #132

Closed
wisdomfusion opened this issue Aug 23, 2017 · 18 comments
Closed

Transplanting TreeSelect, Transfer, Upload from antd? #132

wisdomfusion opened this issue Aug 23, 2017 · 18 comments

Comments

@wisdomfusion
Copy link


[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here

Current behavior

We can't find TreeSelect, Transfer, Upload components till now.

Expected behavior

Is there a schedule for transplanting those components to ng-zorro from antd?

Looking forward for the whole set of components from antd.

Thanks.

@vthinkxie
Copy link
Member

vthinkxie commented Aug 23, 2017

The most important thing we need to do is to keep all bugs clean until 0.5.0 final version released.
TreeSelect Transfer and Upload components is on the schedule, but we can not promise the exact time.
And PR is welcome.

@standbyme
Copy link
Contributor

Upload component has been mentioned in #89.
@vthinkxie

@standbyme
Copy link
Contributor

Should the basic Upload Component be abstracted as described in react-component/upload and https://github.com/ant-design/ant-design/tree/master/components/upload ?

@vthinkxie
Copy link
Member

vthinkxie commented Aug 30, 2017

@thegatheringstorm
Just keep the api and style file https://github.com/ant-design/ant-design/tree/master/components/upload/style same as react version

@standbyme
Copy link
Contributor

Okay

@standbyme
Copy link
Contributor

Should I send you all the code for the upload component at once?Or,Send you the basic code so that you can judge whether my architecture has any problems earlier. @vthinkxie

@vthinkxie
Copy link
Member

@thegatheringstorm
You can submit your pr any time, we will review it after you finish your work.
thanks a lot.

@standbyme
Copy link
Contributor

Okay 😄

@standbyme
Copy link
Contributor

standbyme commented Sep 3, 2017

HttpModule is only needed when uploading.
Should I

import { HttpModule }    from '@angular/http';

in AppComponent?
I really don't know how to deal with this.

And,in react-component/upload,a simple but useful tool has been written there.
Request.js

Which should I use (Request.js or the Http in Angular)?

The essence of the question is whether I should maintain consistency of style or make full use of the Angular

@vthinkxie
Copy link
Member

@thegatheringstorm please use the HttpClientModule
import { HttpClientModule } from '@angular/common/http'
you can find more information here
https://angular.cn/guide/http

@standbyme
Copy link
Contributor

如何在 组件 中使用 HttpClientModule ?能仅仅在组件中使用 HttpClientModule 而不必把该组件转换为 Module 吗?

// app.module.ts:

import {NgModule} from '@angular/core';
import {BrowserModule} from '@angular/platform-browser';

// Import HttpClientModule from @angular/common/http
import {HttpClientModule} from '@angular/common/http';

@NgModule({
  imports: [
    BrowserModule,
    // Include it under 'imports' in your application module
    // after BrowserModule.
    HttpClientModule,
  ],
})
export class MyAppModule {}

这里只有定义为 MyAppModule(Module) 才能使用 HttpClientModule 吧。可是我们的上传组件是一个组件不是 Module 啊。
还望指教 😃

@vthinkxie
Copy link
Member

@thegatheringstorm have a look at the source code, all components are export as modules

@standbyme
Copy link
Contributor

Thanks

@murraybauer
Copy link

Looks like Tree comp has been added now, but still missing Tree Select.

@jackywang615
Copy link

@vthinkxie treeselect组件有计划开发么,这个在复杂表单中应用还是挺多的

@vthinkxie
Copy link
Member

treeselect将在1.0正式版中放出

@vthinkxie
Copy link
Member

closed by #1477

@lock
Copy link

lock bot commented Jun 1, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants