Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select tree-select and maybe more: click close button on tag should not open panels #2276

Closed
wzhudev opened this issue Oct 15, 2018 · 4 comments
Closed

select tree-select and maybe more: click close button on tag should not open panels #2276

wzhudev opened this issue Oct 15, 2018 · 4 comments
Assignees
@hsuanxyz
Labels
💪 Enhancement

Comments

@wzhudev
Copy link
Member

wzhudev commented Oct 15, 2018 •
edited
Loading

According to antd, clicking on close icon should not open panels: https://ant.design/components/tree-select-cn/#components-tree-select-demo-multiple. This causing troubles when user only want to remove some selections. The select panel displayed would interfere users' next action.
@wzhudev wzhudev self-assigned this Oct 15, 2018
@wzhudev wzhudev assigned hsuanxyz and unassigned wzhudev Oct 16, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Oct 17, 2018
@hsuanxyz
fix(module:select,tree-select): prevent pop the dropdown when close c…
51cf722 
…licka

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close NG-ZORRO#2276
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Oct 17, 2018
@hsuanxyz
fix(module:select,tree-select): prevent pop the dropdown when close c…
711eee4 
…lick

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close NG-ZORRO#2276
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Oct 17, 2018
@hsuanxyz
fix(module:select,tree-select): prevent pop the dropdown when click r…
e2e8626 
…emove

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close NG-ZORRO#2276
@hsuanxyz hsuanxyz mentioned this issue Oct 17, 2018
Merged
3 tasks
@IssueHuntBot
Copy link

@BoostIO funded this issue with $30. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@hsuanxyz has started working. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@hsuanxyz has submitted output. Visit this issue on Issuehunt

@IssueHuntBot
Copy link

@vthinkxie has rewarded. See it on IssueHunt

hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz @vthinkxie
fix(module:select,tree-select): prevent pop the dropdown when click r…
dee1021 
…emove (NG-ZORRO#2290)

* fix(module:select,tree-select): prevent pop the dropdown when click remove

ref:
- ant-design/ant-design#10274
- react-component/select#296
- react-component/tree-select#110

close NG-ZORRO#2276

* test(module:tree-select): fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
💪 Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wzhudev @hsuanxyz @IssueHuntBot