Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nzCustomContent support for nz-select too #2946

Closed
thinkdj opened this issue Feb 21, 2019 · 6 comments
Closed

nzCustomContent support for nz-select too #2946

thinkdj opened this issue Feb 21, 2019 · 6 comments
Labels
Component: Select 👨‍🏭 Some one working on this A community member has started working on this

Comments

@thinkdj
Copy link

thinkdj commented Feb 21, 2019 •
edited
Loading

What problem does this feature solve?

It's great that we can customize the content of nz-option. However, that same custom-content functionality is missing for the selected item in nz-select

What does the proposed API look like?

< nz-select nzCustomContent="selectedValueTemplate" >
.... [options]
< /nz-select >
@andrew-yangy
Copy link
Contributor

It looks a very reasonable one, our team is struggling with the same requirement atm, happy to make a pr for it.

@caoyuanqi
Copy link

Yes, this feature is very useful.

@vthinkxie
Copy link
Member

Hi @ddvkid
Just feel free to submit pr :)
thanks for your contribution!

@andrew-yangy andrew-yangy mentioned this issue Mar 11, 2019
Merged
3 tasks
andrew-yangy added a commit to andrew-yangy/ng-zorro-antd that referenced this issue Mar 12, 2019
@andrew-yangy
feat(module:select): support custom template in select component
c5f53d5 
close NG-ZORRO#2946
@ishowman
Copy link

@thinkdj thanks.This is a useful feature

@ishowman
Copy link

@vthinkxie will it release in next version?

@ishowman ishowman mentioned this issue Mar 28, 2019
Closed
andrew-yangy added a commit to andrew-yangy/ng-zorro-antd that referenced this issue Mar 28, 2019
@andrew-yangy
feat(module:select): support custom template in select component
2c6290a 
close NG-ZORRO#2946
@vthinkxie vthinkxie removed their assignment Apr 18, 2019
@vthinkxie vthinkxie added the 👨‍🏭 Some one working on this A community member has started working on this label Apr 18, 2019
@thinkdj
Copy link
Author

thinkdj commented May 28, 2019

This was done by ~March 11 by ddvkid. When can we expect a merge ?

andrew-yangy added a commit to andrew-yangy/ng-zorro-antd that referenced this issue Jun 20, 2019
@andrew-yangy
feat(module:select): support custom template in select component
ed7b8af 
close NG-ZORRO#2946
andrew-yangy added a commit to andrew-yangy/ng-zorro-antd that referenced this issue Jun 20, 2019
@andrew-yangy
feat(module:select): support custom template in select component
5e42933 
close NG-ZORRO#2946
andrew-yangy added a commit to andrew-yangy/ng-zorro-antd that referenced this issue Jun 22, 2019
@andrew-yangy
feat(module:select): support custom template in select component
8ac3982 
close NG-ZORRO#2946
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@andrew-yangy @Ricbet
feat(module:select): support custom template in select component (NG-…
8f60af7 
…ZORRO#3071)

close NG-ZORRO#2946
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@andrew-yangy @vthinkxie
feat(module:select): support custom template in select component (NG-…
7a80350 
…ZORRO#3071)

close NG-ZORRO#2946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Select 👨‍🏭 Some one working on this A community member has started working on this
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@thinkdj @vthinkxie @caoyuanqi @andrew-yangy @ishowman @hsuanxyz