Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): remove icon test module export #3002

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 1, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Remove exportation of NzIconTestModule.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Mar 1, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0ea5c18

https://deploy-preview-3002--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #3002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3002   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files         550      550           
  Lines       11452    11452           
  Branches      813      813           
=======================================
  Hits        11149    11149           
  Misses        190      190           
  Partials      113      113

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 623a9ff...0ea5c18. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 28edb53 into NG-ZORRO:master Mar 1, 2019
@wzhudev wzhudev deleted the icon-test-module branch March 4, 2019 09:29
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants