Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(module:modal): support use directive to define the footer #3036

Merged
merged 10 commits into from
Jul 19, 2019
Merged

feat(module:modal): support use directive to define the footer #3036

merged 10 commits into from
Jul 19, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Mar 6, 2019

close #3035

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Mar 6, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit 0929087

https://deploy-preview-3036--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz marked this pull request as ready for review March 12, 2019 06:37
@codecov
Copy link

codecov bot commented Mar 12, 2019 •
edited
Loading

Codecov Report

Merging #3036 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
- Coverage   95.39%   95.38%   -0.01%     
==========================================
  Files         712      700      -12     
  Lines       14633    14506     -127     
  Branches     1929     1915      -14     
==========================================
- Hits        13959    13837     -122     
+ Misses        244      243       -1     
+ Partials      430      426       -4
Impacted Files Coverage Δ
components/modal/nz-modal.component.ts 95.94% <100%> (+0.86%) ⬆️
components/modal/nz-modal.module.ts 100% <100%> (ø) ⬆️
components/modal/public-api.ts 100% <100%> (ø) ⬆️
components/modal/nz-modal-footer.directive.ts 71.42% <71.42%> (ø)
...mponents/descriptions/nz-descriptions.component.ts 95.83% <0%> (-2.89%) ⬇️
components/message/nz-message.service.ts 97.95% <0%> (-2.05%) ⬇️
components/tabs/nz-tab.component.ts 96% <0%> (-0.56%) ⬇️
components/carousel/nz-carousel.component.ts 93.71% <0%> (-0.54%) ⬇️
components/input/nz-autosize.directive.ts 91.76% <0%> (-0.38%) ⬇️
components/tabs/nz-tabs-nav.component.ts 90.62% <0%> (-0.34%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8a58c...6e7524d. Read the comment docs.

@weekly-digest weekly-digest bot mentioned this pull request Apr 1, 2019
Closed
@vthinkxie vthinkxie self-assigned this Jun 25, 2019
@vthinkxie vthinkxie self-requested a review June 25, 2019 10:52
@vthinkxie vthinkxie requested review from wzhudev and removed request for vthinkxie June 25, 2019 10:52
@vthinkxie vthinkxie removed their assignment Jun 25, 2019
@hsuanxyz hsuanxyz force-pushed the feat/modal-footer branch 2 times, most recently from b535ad4 to 6e7524d Compare July 19, 2019 02:54
wzhudev
wzhudev approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wzhudev wzhudev merged commit f022a0f into NG-ZORRO:master Jul 19, 2019
@darshanrampatel darshanrampatel mentioned this pull request Oct 24, 2019
Closed
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
feat(module:modal): support use directive to define the footer (NG-ZO…
4e32857 
…RRO#3036)

* feat(module:modal): support use directive to define the footer

close NG-ZORRO#3035

* docs(module:modal): add custom footer demo

* test(module:modal): add test

* test(module:modal): add test

* fix(module:modal): fix type

* test(module:modal): fix test

* chore: rebase master

* chore: rebase master

* test(module:modal): fix test

* test(module:modal): fix test
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz
feat(module:modal): support use directive to define the footer (NG-ZO…
ac64116 
…RRO#3036)

* feat(module:modal): support use directive to define the footer

close NG-ZORRO#3035

* docs(module:modal): add custom footer demo

* test(module:modal): add test

* test(module:modal): add test

* fix(module:modal): fix type

* test(module:modal): fix test

* chore: rebase master

* chore: rebase master

* test(module:modal): fix test

* test(module:modal): fix test
@hsuanxyz hsuanxyz deleted the feat/modal-footer branch August 5, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees

@wzhudev wzhudev

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] modal support use directive to define the footer
3 participants
@hsuanxyz @wzhudev @vthinkxie