Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:auto-complete): enter-keydown event should not be prevent when the panel is closed #3342

Merged
merged 2 commits into from
Apr 25, 2019
Merged

fix(module:auto-complete): enter-keydown event should not be prevent when the panel is closed #3342

merged 2 commits into from
Apr 25, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3340

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Apr 23, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 250997a

https://deploy-preview-3342--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 23, 2019 •
edited
Loading

Codecov Report

Merging #3342 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3342      +/-   ##
==========================================
+ Coverage   97.44%   97.44%   +<.01%     
==========================================
  Files         606      606              
  Lines       11931    11932       +1     
  Branches      869      869              
==========================================
+ Hits        11626    11627       +1     
  Misses        196      196              
  Partials      109      109
Impacted Files Coverage Δ
...auto-complete/nz-autocomplete-trigger.directive.ts 99.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e72f70...250997a. Read the comment docs.

wzhudev
wzhudev approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 414b428 into NG-ZORRO:master Apr 25, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz @Ricbet
fix(module:auto-complete): enter-keydown event should not be prevent …
7048e11 
…when the panel is closed (NG-ZORRO#3342)

* fix(module:auto-complete): enter-keydown event should not be prevent when the panel is closed

close NG-ZORRO#3340

* chore(module:auto-complete): clean code
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz
fix(module:auto-complete): enter-keydown event should not be prevent …
8f60704 
…when the panel is closed (NG-ZORRO#3342)

* fix(module:auto-complete): enter-keydown event should not be prevent when the panel is closed

close NG-ZORRO#3340

* chore(module:auto-complete): clean code
@hsuanxyz hsuanxyz deleted the fix/autocomplete-enter branch August 5, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzhudev wzhudev wzhudev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsuanxyz @wzhudev