Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:transfer): add nzShowSelectAll & nzRenderList properties #3588

Merged
merged 16 commits into from
Jun 21, 2019
Merged

feat(module:transfer): add nzShowSelectAll & nzRenderList properties #3588

merged 16 commits into from
Jun 21, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jun 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

cipchk and others added 16 commits December 8, 2018 16:41
chore: merge master

Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by:  <krokofant@users.noreply.github.com>
Co-authored-by: Wilson Zeng <jackzcs@gmail.com>
Co-authored-by: null <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: Ekko <danranvm@gmail.com>
Co-authored-by: null <33438314+myh6666@users.noreply.github.com>
chore: merge master

Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by: Wilson Zeng <jackzcs@gmail.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: GQ <tonny008@163.com>
Co-authored-by:  <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: null <231785421@qq.com>
Co-authored-by: simplejason <tangjie@yinspect.com>
Co-authored-by: null <37918438+dodobelieve@users.noreply.github.com>
chore: merge master

Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by:  <coderpoet@outlook.com>
Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by: Freax <huangyanxiong2013@gmail.com>
chore: merge master

Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by: Rasheed Rahman <11582800+radiumrasheed@users.noreply.github.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: null <kayphay92@gmail.com>
Co-authored-by: simplejason <tangjie@yinspect.com>
chore: merge master

Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: Ethan Zhao <zdpluto@gmail.com>
Co-authored-by: Wendell <wendzhue@gmail.com>
chore: merge master

Co-authored-by:  <kekehao1212@outlook.com>
Co-authored-by:  <33472860+ng-zorro-bot@users.noreply.github.com>
chore: merge master

Co-authored-by: Ekko <danranvm@gmail.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: simplejason <tangjie@yinspect.com>
Co-authored-by: Guillem Palomar <guillem.palomar.agramunt@gmail.com>
Co-authored-by: Nickbing Lao <giscafer@outlook.com>
Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by:  <pwjay.ok@163.com>
Co-authored-by: Sunny Liu <lx1036@126.com>
Co-authored-by:  <kekehao1212@outlook.com>
Co-authored-by: Wendell <wendzhue@gmail.com>
chore: merge master

Co-authored-by:  <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by: 雪狼 <asnowwolf@users.noreply.github.com>
Co-authored-by: simplejason <tangjie@yinspect.com>
Co-authored-by:  <pwjay.ok@163.com>
Co-authored-by: olive.wang <olive@olivewind.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by:  <binglingshuang@163.com>
chore: merge master

Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: JerryHong <s6323859@gmail.com>
Co-authored-by: Wendell <wendzhue@gmail.com>
Co-authored-by: null <binglingshuang@163.com>
Co-authored-by: Wenqi <1264578441@qq.com>
Co-authored-by: Joshua Harris <joshuadaleharris@gmail.com>
Co-authored-by: Gleb Mikheev <mikheev@betaagency.ru>
Co-authored-by: null <2535612040@qq.com>
Co-authored-by: simplejason <simplejason.coder@gmail.com>
Co-authored-by: ivan <ivanwonder@outlook.com>
Co-authored-by: null <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: vthinkxie <vthinkxie@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Jun 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit ab336d9

https://deploy-preview-3588--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #3588 into master will increase coverage by <.01%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3588      +/-   ##
==========================================
+ Coverage   95.72%   95.73%   +<.01%     
==========================================
  Files         690      690              
  Lines       13708    13724      +16     
  Branches     1824     1824              
==========================================
+ Hits        13122    13138      +16     
  Misses        198      198              
  Partials      388      388
Impacted Files Coverage Δ
components/transfer/nz-transfer.component.ts 98.23% <100%> (+0.23%) ⬆️
components/transfer/nz-transfer-list.component.ts 97.1% <84.61%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b5d35...ab336d9. Read the comment docs.

@vthinkxie vthinkxie requested a review from wzhudev June 21, 2019 09:37
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants