Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:code-editor): add code editor component #3706

Merged
merged 3 commits into from
Aug 13, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jul 2, 2019
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #3706 into master will decrease coverage by 0.94%.
The diff coverage is 11.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3706      +/-   ##
=========================================
- Coverage   93.25%   92.3%   -0.95%     
=========================================
  Files         500     506       +6     
  Lines       10615   10749     +134     
  Branches     1924    1941      +17     
=========================================
+ Hits         9899    9922      +23     
- Misses        301     411     +110     
- Partials      415     416       +1
Impacted Files Coverage Δ
components/core/util/tick.ts 0% <0%> (ø)
components/code-editor/nz-code-editor.component.ts 10.81% <10.81%> (ø)
components/code-editor/nz-code-editor.module.ts 100% <100%> (ø)
components/code-editor/nz-code-editor.service.ts 2.08% <2.08%> (ø)
components/code-editor/demo/basic.ts 50% <50%> (ø)
...mponents/code-editor/nz-code-editor.definitions.ts 83.33% <83.33%> (ø)
components/rate/nz-rate.component.ts 93.1% <0%> (-4.6%) ⬇️
components/time-picker/time-holder.ts 96.49% <0%> (-0.88%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d27fb6...0991f23. Read the comment docs.

@wzhudev wzhudev requested a review from vthinkxie July 2, 2019 07:11
@netlify
Copy link

netlify bot commented Jul 2, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0991f23

https://deploy-preview-3706--ng-zorro-master.netlify.com

@vthinkxie vthinkxie merged commit df78b2e into NG-ZORRO:master Aug 13, 2019
@pr-triage pr-triage bot added the PR: merged label Aug 13, 2019
@wzhudev wzhudev deleted the migrate-plus-code-editor branch August 14, 2019 01:42
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:code-editor): add component

* docs: change docs

* fix: remove style export in primary entrance
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:code-editor): add component

* docs: change docs

* fix: remove style export in primary entrance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants