Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:tree): unexpected disappear of tree-node #3748

Merged
merged 9 commits into from
Jul 19, 2019
Merged

fix(module:tree): unexpected disappear of tree-node #3748

merged 9 commits into from
Jul 19, 2019

Conversation

orzyyyy
Copy link
Contributor

@orzyyyy orzyyyy commented Jul 8, 2019 •
edited
Loading

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Issue Number:

To close #3739

What is the new behavior?

Does this PR introduce a breaking change?

  • No

Other information

I'm a new of ng and nz, and I'm working on how to complete test case, maybe take lots of time...

@pr-triage pr-triage bot added the PR: draft label Jul 8, 2019
@netlify
Copy link

netlify bot commented Jul 8, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit 069a860

https://deploy-preview-3748--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 8, 2019 •
edited
Loading

Codecov Report

Merging #3748 into master will decrease coverage by 0.03%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3748      +/-   ##
==========================================
- Coverage    95.4%   95.37%   -0.04%     
==========================================
  Files         711      711              
  Lines       14593    14608      +15     
  Branches     1924     1927       +3     
==========================================
+ Hits        13923    13932       +9     
- Misses        243      248       +5     
- Partials      427      428       +1
Impacted Files Coverage Δ
components/core/tree/nz-tree-base-node.ts 90.9% <ø> (ø) ⬆️
components/tree/nz-tree-node.component.ts 90.57% <56.25%> (-2.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e9e14...069a860. Read the comment docs.

@orzyyyy orzyyyy marked this pull request as ready for review July 8, 2019 12:42
@orzyyyy orzyyyy changed the title fix: unexpected disappear of tree-node fix(module:tree): unexpected disappear of tree-node Jul 8, 2019
@orzyyyy
Copy link
Contributor Author

orzyyyy commented Jul 11, 2019 •
edited
Loading

What can I do with coverage?
I'm working on arch linux and have never change options of line break, so it's LF, but why this break coverage?

My bad, change fit to it fix the breaking coverage.

@orzyyyy orzyyyy changed the title fix(module:tree): unexpected disappear of tree-node [WIP] fix(module:tree): unexpected disappear of tree-node Jul 13, 2019
@orzyyyy
Copy link
Contributor Author

orzyyyy commented Jul 14, 2019 •
edited
Loading

Is there anything wrong with the code? I don't know why netlify crashed.

@wzhudev
Copy link
Member

wzhudev commented Jul 14, 2019

@orzyyyy Please rebase to the master branch.

@orzyyyy
Copy link
Contributor Author

orzyyyy commented Jul 14, 2019

I have tried, but it doesn't work.

@orzyyyy orzyyyy changed the title [WIP] fix(module:tree): unexpected disappear of tree-node fix(module:tree): unexpected disappear of tree-node Jul 14, 2019
@orzyyyy
Copy link
Contributor Author

orzyyyy commented Jul 17, 2019

https://travis-ci.org/NG-ZORRO/ng-zorro-antd/jobs/559920055#L1201
Is there anything I can do with this?

@hsuanxyz
Copy link
Member

@orzyyyy We fixed the @angular/cdk breaking change, Please rebase to the master branch.

wzhudev
wzhudev approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wzhudev wzhudev merged commit 1ff176e into NG-ZORRO:master Jul 19, 2019
@orzyyyy orzyyyy deleted the fix branch July 19, 2019 03:00
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@orzyyyy @Ricbet
fix(module:tree): unexpected disappear of tree-node (NG-ZORRO#3748)
d8a6f74 
close NG-ZORRO#3739

* fix: unexpected disappear of tree-node

* test(module:nz-tree): update case

* perf: add prop shouldHide to nzTreeNode

* chore: rename prop shouldHide to canHide

* fix: check match status of upstream and downstream tree node

* test(module:nz-tree): update fit to it

* chore: remove useless access modifier

* test: update cases

* test: combine two cases
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@orzyyyy
fix(module:tree): unexpected disappear of tree-node (NG-ZORRO#3748)
0ae3f23 
close NG-ZORRO#3739

* fix: unexpected disappear of tree-node

* test(module:nz-tree): update case

* perf: add prop shouldHide to nzTreeNode

* chore: rename prop shouldHide to canHide

* fix: check match status of upstream and downstream tree node

* test(module:nz-tree): update fit to it

* chore: remove useless access modifier

* test: update cases

* test: combine two cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simplejason simplejason simplejason left review comments

@wzhudev wzhudev wzhudev approved these changes

@hsuanxyz hsuanxyz hsuanxyz approved these changes

Assignees

@simplejason simplejason

Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

树组件的nzHideUnMatched属性存在bug
4 participants
@orzyyyy @wzhudev @hsuanxyz @simplejason