Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:resizable): add resizable component #3771

Merged
merged 10 commits into from
Aug 13, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3701

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@pr-triage pr-triage bot added the PR: draft label Jul 11, 2019
@netlify
Copy link

netlify bot commented Jul 11, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0ba9e6c

https://deploy-preview-3771--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #3771 into master will increase coverage by 0.01%.
The diff coverage is 93.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3771      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.01%     
==========================================
  Files         489      500      +11     
  Lines       10378    10590     +212     
  Branches     1889     1915      +26     
==========================================
+ Hits         9697     9897     +200     
+ Misses        279      278       -1     
- Partials      402      415      +13
Impacted Files Coverage Δ
components/resizable/demo/lock-aspect-ratio.ts 100% <100%> (ø)
components/resizable/demo/customize.ts 100% <100%> (ø)
components/resizable/nz-resizable.module.ts 100% <100%> (ø)
components/resizable/demo/basic.ts 100% <100%> (ø)
components/resizable/demo/preview.ts 100% <100%> (ø)
components/resizable/nz-resizable.service.ts 100% <100%> (ø)
components/resizable/nz-resize-handle.component.ts 100% <100%> (ø)
components/core/util/ensure-in-bounds.ts 100% <100%> (ø)
components/resizable/demo/grid.ts 100% <100%> (ø)
...omponents/resizable/nz-resize-handles.component.ts 83.33% <83.33%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeccb20...0ba9e6c. Read the comment docs.

@hsuanxyz hsuanxyz force-pushed the new/resizable branch 2 times, most recently from 18637bc to 6af1c9a Compare July 15, 2019 01:52
@hsuanxyz hsuanxyz marked this pull request as ready for review July 15, 2019 01:58
@hsuanxyz hsuanxyz requested a review from vthinkxie July 15, 2019 06:24
@hsuanxyz hsuanxyz force-pushed the new/resizable branch 2 times, most recently from 2f389b2 to 45cfbfc Compare July 24, 2019 11:57
Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is on 🔥🔥🔥 but we can still improve it.

components/resizable/doc/index.en-US.md Show resolved Hide resolved
components/resizable/doc/index.zh-CN.md Outdated Show resolved Hide resolved
@vthinkxie vthinkxie merged commit 5e71739 into NG-ZORRO:master Aug 13, 2019
@pr-triage pr-triage bot added the PR: merged label Aug 13, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:resizable): add resizable component

ref NG-ZORRO#3701

* docs(module:resizable): add layout demo

* test(module:resizable): add test cases

* docs(module:resizable): add module file

* test(module:resizable): add test cases

* docs: add experimental docs

* refactor(module:resizable): refactor size calculation

* docs(module:resizable): update docs

* docs: add static paths

* docs: update
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:resizable): add resizable component

ref NG-ZORRO#3701

* docs(module:resizable): add layout demo

* test(module:resizable): add test cases

* docs(module:resizable): add module file

* test(module:resizable): add test cases

* docs: add experimental docs

* refactor(module:resizable): refactor size calculation

* docs(module:resizable): update docs

* docs: add static paths

* docs: update
@hsuanxyz hsuanxyz deleted the new/resizable branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants