Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:slider): support nzTooltipPlacement #4007

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Users can set the default position of the tooltip by nzTooltipPlacement.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 14, 2019

Deploy preview for ng-zorro-master ready!

Built with commit f13eece

https://deploy-preview-4007--ng-zorro-master.netlify.com

@wzhudev wzhudev force-pushed the slider-tooltip-position branch 2 times, most recently from c795f86 to 88824c9 Compare August 14, 2019 12:14
@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #4007 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4007      +/-   ##
==========================================
+ Coverage   92.31%   92.33%   +0.02%     
==========================================
  Files         513      513              
  Lines       10796    10800       +4     
  Branches     1954     1955       +1     
==========================================
+ Hits         9966     9972       +6     
+ Misses        411      409       -2     
  Partials      419      419
Impacted Files Coverage Δ
components/slider/nz-slider.component.ts 91.87% <100%> (+0.04%) ⬆️
components/slider/nz-slider-handle.component.ts 95.55% <100%> (+0.1%) ⬆️
...mponents/tooltip/base/nz-tooltip-base.directive.ts 90.81% <100%> (+1.12%) ⬆️
components/popconfirm/nz-popconfirm.directive.ts 100% <100%> (ø) ⬆️
...s/tooltip/base/nz-tooltip-base-legacy.component.ts 100% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66afcf0...f13eece. Read the comment docs.

@wzhudev wzhudev changed the title feat(module:progress): support nzTooltipPlacement feat(module:slider): support nzTooltipPlacement Aug 15, 2019
@wzhudev
Copy link
Member Author

wzhudev commented Aug 15, 2019

I don't know how I messed sliderwith progress. Please take care when merging this.

@wzhudev wzhudev force-pushed the slider-tooltip-position branch 3 times, most recently from a0db9e1 to bd0fc8b Compare August 27, 2019 09:59
refactor(module:progress): not use deprecated API internally
@hsuanxyz hsuanxyz merged commit d6a2968 into NG-ZORRO:master Sep 9, 2019
@wzhudev wzhudev deleted the slider-tooltip-position branch September 20, 2019 02:22
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
refactor(module:progress): not use deprecated API internally
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
refactor(module:progress): not use deprecated API internally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants