Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:resizable): listen document events when resizing start #4021

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Aug 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 59bfdcf

https://deploy-preview-4021--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #4021 into master will decrease coverage by 0.27%.
The diff coverage is 98.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4021      +/-   ##
==========================================
- Coverage   92.41%   92.13%   -0.28%     
==========================================
  Files         506      507       +1     
  Lines       10749    10775      +26     
  Branches     1942     1945       +3     
==========================================
- Hits         9934     9928       -6     
- Misses        400      431      +31     
- Partials      415      416       +1
Impacted Files Coverage Δ
components/resizable/nz-resizable-utils.ts 0% <0%> (ø)
components/core/testing/event-objects.ts 85.71% <100%> (ø) ⬆️
components/resizable/nz-resizable.directive.ts 92.05% <100%> (+0.77%) ⬆️
components/resizable/nz-resize-handle.component.ts 100% <100%> (ø) ⬆️
components/resizable/nz-resizable.service.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tabs-ink-bar.directive.ts 60% <0%> (-30%) ⬇️
components/core/scroll/nz-scroll.service.ts 38.29% <0%> (-23.41%) ⬇️
components/checkbox/nz-checkbox-group.component.ts 90.9% <0%> (-9.1%) ⬇️
components/radio/nz-radio.component.ts 93.61% <0%> (-6.39%) ⬇️
components/switch/nz-switch.component.ts 92.68% <0%> (-4.88%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 272e32a...59bfdcf. Read the comment docs.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev
Copy link
Member

wzhudev commented Sep 6, 2019

Maybe we can extract dragging logic into an isolated service. May be used by other components in the future.

@hsuanxyz hsuanxyz merged commit 66afcf0 into NG-ZORRO:master Sep 9, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the pref/resizable branch August 5, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants