Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tag): nzNoAnimation not working #4257

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Oct 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4244

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Oct 8, 2019

Deploy preview for ng-zorro-master ready!

Built with commit dd4d875

https://deploy-preview-4257--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #4257 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4257      +/-   ##
=========================================
+ Coverage    92.3%   92.3%   +<.01%     
=========================================
  Files         519     519              
  Lines       10963   10965       +2     
  Branches     1984    1985       +1     
=========================================
+ Hits        10119   10121       +2     
  Misses        420     420              
  Partials      424     424
Impacted Files Coverage Δ
components/tag/nz-tag.component.ts 96.87% <75%> (-3.13%) ⬇️
components/time-picker/time-holder.ts 96.49% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 418adb9...dd4d875. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 63f947e into NG-ZORRO:master Oct 12, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@hsuanxyz hsuanxyz deleted the fix/tag-no-animation branch August 5, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants