feat(module:icon): support add icon in feat modules & refactor #4711

wzhudev · 2020-01-22T03:09:55Z

BREAKING CHANGE:

NZ_ICON_DEFAULT_TWOTONE_COLOR is removed. Use NzGlobalConfigService instead.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

zorro-bot · 2020-01-22T03:09:58Z

This preview will be available after the AzureCI is passed.

codecov · 2020-01-24T11:31:07Z

Codecov Report

Merging #4711 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4711      +/-   ##
==========================================
- Coverage   91.49%   91.43%   -0.06%     
==========================================
  Files         535      539       +4     
  Lines       13589    13623      +34     
  Branches     2028     2031       +3     
==========================================
+ Hits        12433    12456      +23     
- Misses        691      698       +7     
- Partials      465      469       +4

Impacted Files	Coverage Δ
components/core/testing/componet-bed.ts	`90.90% <ø> (ø)`
components/icon/testing/nz-icon-test.module.ts	`100.00% <ø> (ø)`
components/icon/icon.directive.ts	`93.22% <100.00%> (ø)`
components/icon/icon.module.ts	`100.00% <100.00%> (ø)`
components/icon/icon.service.ts	`96.66% <100.00%> (ø)`
components/table/src/table/tbody.component.ts	`85.71% <0.00%> (-14.29%)`	⬇️
components/table/src/table/tr-measure.component.ts	`86.95% <0.00%> (-13.05%)`	⬇️
...ents/time-picker/nz-time-picker-panel.component.ts
components/time-picker/nz-time-picker.module.ts
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98761f5...f5addf4. Read the comment docs.

hsuanxyz · 2020-02-19T03:01:37Z

@wendellhu95 测试挂了

vthinkxie · 2020-03-15T07:07:58Z

components/icon/doc/index.en-US.md

+
+```ts
+@NgModule({
+  imports: [CommonModule, NzIconModule.patch([QuestionOutline])],


maybe NzIconModule .forChild is better?

and change { provide: NZ_ICONS, useValue: icons } to forRoot

增加了，已经在文档中去除了直接提供 NZ_ICONS 的使用方法。

patch的方法改成forChild?

wzhudev · 2020-03-15T07:51:52Z

GitHub 这是怎么了，我已经 rebase 到了 master

vthinkxie · 2020-03-15T08:07:55Z

components/icon/icons.ts

+  StarFill,
+  UploadOutline,
+  UpOutline
+];


这部分的图标是不是可以通过forChild直接在每个组件里面import

feat(module:icon): support import icon in submodules fix: fix patch feat: rename API docs: fix doc fix: remove redundant code docs: fix unrenamed API chore(module:icon): refactor test: fix tests fix: fix tests BREAKING CHANGE: - `NZ_ICON_DEFAULT_TWOTONE_COLOR` is removed. Use `NzGlobalConfigService` instead. chore: remove strange file test: fix test feat: add forRoot docs: change doc docs: fix icon English doc

vthinkxie

some topo problem will fix later

feat(module:icon): support import icon in submodules fix: fix patch feat: rename API docs: fix doc fix: remove redundant code docs: fix unrenamed API chore(module:icon): refactor test: fix tests fix: fix tests BREAKING CHANGE: - `NZ_ICON_DEFAULT_TWOTONE_COLOR` is removed. Use `NzGlobalConfigService` instead. chore: remove strange file test: fix test feat: add forRoot docs: change doc docs: fix icon English doc

wzhudev added this to the 9.0.0 milestone Jan 22, 2020

pr-triage bot added the PR: unreviewed label Jan 22, 2020

auto-assign bot assigned hsuanxyz Jan 22, 2020

weekly-digest bot mentioned this pull request Jan 26, 2020

Weekly Digest (19 January, 2020 - 26 January, 2020) #4734

Closed

wenqi73 requested a review from hsuanxyz February 3, 2020 08:06

weekly-digest bot mentioned this pull request Feb 9, 2020

Weekly Digest (2 February, 2020 - 9 February, 2020) #4760

Closed

wzhudev mentioned this pull request Feb 13, 2020

feat(module:icon): support import icon in submodules #4673

Closed

3 tasks

wzhudev force-pushed the icon-9.0 branch from 0204483 to d168809 Compare February 13, 2020 01:32

weekly-digest bot mentioned this pull request Feb 16, 2020

Weekly Digest (9 February, 2020 - 16 February, 2020) #4788

Closed

wzhudev force-pushed the icon-9.0 branch from c5d9f5e to 4328538 Compare February 19, 2020 08:26

wzhudev changed the title ~~chore(module:icon): refactor~~ feat(module:icon): support add icon in feat modules Feb 19, 2020

weekly-digest bot mentioned this pull request Feb 23, 2020

Weekly Digest (16 February, 2020 - 23 February, 2020) #4810

Closed

wzhudev changed the title ~~feat(module:icon): support add icon in feat modules~~ feat(module:icon): support add icon in feat modules & refactor Feb 28, 2020

weekly-digest bot mentioned this pull request Mar 1, 2020

Weekly Digest (23 February, 2020 - 1 March, 2020) #4824

Closed

vthinkxie reviewed Mar 15, 2020

View reviewed changes

wzhudev force-pushed the icon-9.0 branch from cb9957e to 3e91c39 Compare March 15, 2020 07:47

vthinkxie reviewed Mar 15, 2020

View reviewed changes

wzhudev force-pushed the icon-9.0 branch from 3e91c39 to f5addf4 Compare March 15, 2020 08:10

vthinkxie approved these changes Mar 15, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Mar 15, 2020

vthinkxie merged commit 0bcd2a9 into NG-ZORRO:master Mar 15, 2020

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Mar 15, 2020

wzhudev deleted the icon-9.0 branch March 15, 2020 09:38

weekly-digest bot mentioned this pull request Mar 15, 2020

Weekly Digest (8 March, 2020 - 15 March, 2020) #4887

Closed

hsuanxyz mentioned this pull request Apr 15, 2020

NG-ZORRO 9.0 #5024

Closed

wzhudev mentioned this pull request Jul 10, 2020

icon user exp improve #4886

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(module:icon): support add icon in feat modules & refactor #4711

feat(module:icon): support add icon in feat modules & refactor #4711

wzhudev commented Jan 22, 2020

zorro-bot bot commented Jan 22, 2020

codecov bot commented Jan 24, 2020 •

edited

hsuanxyz commented Feb 19, 2020

vthinkxie Mar 15, 2020

vthinkxie Mar 15, 2020

wzhudev Mar 15, 2020

vthinkxie Mar 15, 2020

wzhudev commented Mar 15, 2020

vthinkxie Mar 15, 2020

vthinkxie left a comment

feat(module:icon): support add icon in feat modules & refactor #4711

feat(module:icon): support add icon in feat modules & refactor #4711

Conversation

wzhudev commented Jan 22, 2020

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

zorro-bot bot commented Jan 22, 2020

codecov bot commented Jan 24, 2020 • edited

Codecov Report

hsuanxyz commented Feb 19, 2020

vthinkxie Mar 15, 2020

Choose a reason for hiding this comment

vthinkxie Mar 15, 2020

Choose a reason for hiding this comment

wzhudev Mar 15, 2020

Choose a reason for hiding this comment

vthinkxie Mar 15, 2020

Choose a reason for hiding this comment

wzhudev commented Mar 15, 2020

vthinkxie Mar 15, 2020

Choose a reason for hiding this comment

vthinkxie left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 24, 2020 •

edited