Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:checkbox): use css empty selector instead of observeContent #4761

Merged
merged 1 commit into from Feb 9, 2020
Merged

perf(module:checkbox): use css empty selector instead of observeContent #4761

merged 1 commit into from Feb 9, 2020

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Feb 9, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 9, 2020

Codecov Report

Merging #4761 into master will decrease coverage by 0.04%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4761      +/-   ##
==========================================
- Coverage   93.26%   93.21%   -0.05%     
==========================================
  Files         506      506              
  Lines       12776    12757      -19     
  Branches     2015     1964      -51     
==========================================
- Hits        11915    11891      -24     
- Misses        451      453       +2     
- Partials      410      413       +3
Impacted Files Coverage Δ
components/checkbox/checkbox.module.ts 100% <ø> (ø)
components/checkbox/checkbox-wrapper.component.ts 100% <100%> (ø)
components/checkbox/checkbox-group.component.ts 100% <100%> (ø)
components/checkbox/checkbox.component.ts 96.29% <80%> (ø)
components/core/util/check.ts 79.06% <0%> (-4.66%) ⬇️
components/time-picker/time-holder.ts 97.31% <0%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6bd51...df84e0c. Read the comment docs.

@vthinkxie vthinkxie merged commit da8821a into NG-ZORRO:master Feb 9, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants