Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tooltip,etc): support custom origin #4849

Merged
merged 6 commits into from Apr 7, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 7, 2020

close #4839

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 7, 2020

Codecov Report

Merging #4849 into master will increase coverage by 0.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4849      +/-   ##
==========================================
+ Coverage   91.53%   91.54%   +0.01%     
==========================================
  Files         535      537       +2     
  Lines       13686    13686              
  Branches     2043     2042       -1     
==========================================
+ Hits        12527    12529       +2     
  Misses        694      694              
+ Partials      465      463       -2     
Impacted Files Coverage Δ
components/popover/popover.ts 94.11% <50.00%> (+0.36%) ⬆️
components/tooltip/base.ts 94.97% <95.65%> (+0.31%) ⬆️
...ents/core/element-patch/element-patch.directive.ts 100.00% <100.00%> (ø)
...ponents/core/element-patch/element-patch.module.ts 100.00% <100.00%> (ø)
components/popconfirm/popconfirm.ts 100.00% <100.00%> (ø)
components/tooltip/tooltip.ts 100.00% <100.00%> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/time-picker/time-picker.component.ts 93.81% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44155a3...e625bc2. Read the comment docs.

@wzhudev wzhudev changed the title feat(module:tooltip,etc): target feat(module:tooltip,etc): support custom origin Mar 8, 2020
@wzhudev wzhudev force-pushed the tooltip-target branch 2 times, most recently from 39a4a16 to ac79683 Compare March 16, 2020 06:25
Wendell Hu added 2 commits March 24, 2020 21:05
feat(module:core): add element patch directive, rename API

chore: rename properties

chore: remove old API

fix: property

fix: typo in demo
@wzhudev wzhudev requested a review from hsuanxyz March 30, 2020 11:02
@wzhudev wzhudev requested a review from hsuanxyz April 1, 2020 03:44
@wzhudev wzhudev merged commit 863fd4b into NG-ZORRO:master Apr 7, 2020
@wzhudev wzhudev deleted the tooltip-target branch April 7, 2020 02:16
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
Ricbet added a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:tooltip,etc): support custom origin (NG-ZORRO#4849)

* chore: sync ant-design v4.1.1 (NG-ZORRO#4987)

Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>

* feat(module:code-editor): upgrade monaco to 0.20.0 and update interfaces (NG-ZORRO#4984)

* fix(module:badge): allow `nzTitle` set to null (NG-ZORRO#4965)

close NG-ZORRO#4776

* chore: add optional chaining and nullish coalescing (NG-ZORRO#4946)

* chore: add optional chaining and nullish coalescing

* test: fix tests

* test: fix tests

* feat(module:space): add new component (NG-ZORRO#4928)

close NG-ZORRO#4913

* feat: support compact theme (NG-ZORRO#4972)

Co-authored-by: Wendell <wendellhu95@gmail.com>
Co-authored-by: ng-zorro-bot <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: Wenqi <1264578441@qq.com>
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popover (and related components) Allow option to target another element for alignment.
2 participants