Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to hide nz-badge title #4776

Closed
krokofant opened this issue Feb 12, 2020 · 3 comments · Fixed by #4965
Closed

Allow to hide nz-badge title #4776

krokofant opened this issue Feb 12, 2020 · 3 comments · Fixed by #4965
Assignees
@hsuanxyz
Labels
Component: Badge

Comments

@krokofant
Copy link
Contributor

What problem does this feature solve?

The non-standalone nz-badge cannot hide the title which appears when hovering the badge.
image

NG-Zorro version: 8.5.2

What does the proposed API look like?

Allow a [nzText]="null" to explicitly hide the title on hover.

<nz-badge [nzCount]="5" [nzText]="null">
  foo bar
</nz-badge>
@weekly-digest weekly-digest bot mentioned this issue Feb 16, 2020
Closed
@hsuanxyz
Copy link
Member

@krokofant Does set [nzCount]="0" work for you?

@krokofant
Copy link
Contributor Author

@hsuanxyz It's not the badge that cannot be hidden - it's the the title text. See this image and note the arrow:
image

Every time you hover badge you'll see a title and it can't be hidden.

@hsuanxyz
Copy link
Member

I see, this is a bug and we'll fix this. Because it has the [nzTitle] property but does not work when the value is null

hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Apr 1, 2020
@hsuanxyz
fix(module:badge): allow nzTitle set to null
0fc420d 
close NG-ZORRO#4776
@hsuanxyz hsuanxyz mentioned this issue Apr 1, 2020
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Apr 7, 2020
@hsuanxyz
fix(module:badge): allow nzTitle set to null (#4965)
a35fb5e 
close #4776
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@hsuanxyz @Ricbet
fix(module:badge): allow nzTitle set to null (NG-ZORRO#4965)
6907204 
close NG-ZORRO#4776
Ricbet added a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@Ricbet @ng-zorro-bot
@hsuanxyz @wenqi73
Sync Zorro (#6)
9f4a87b 
* feat(module:tooltip,etc): support custom origin (NG-ZORRO#4849)

* chore: sync ant-design v4.1.1 (NG-ZORRO#4987)

Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>

* feat(module:code-editor): upgrade monaco to 0.20.0 and update interfaces (NG-ZORRO#4984)

* fix(module:badge): allow `nzTitle` set to null (NG-ZORRO#4965)

close NG-ZORRO#4776

* chore: add optional chaining and nullish coalescing (NG-ZORRO#4946)

* chore: add optional chaining and nullish coalescing

* test: fix tests

* test: fix tests

* feat(module:space): add new component (NG-ZORRO#4928)

close NG-ZORRO#4913

* feat: support compact theme (NG-ZORRO#4972)

Co-authored-by: Wendell <wendellhu95@gmail.com>
Co-authored-by: ng-zorro-bot <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: Wenqi <1264578441@qq.com>
@hsuanxyz hsuanxyz mentioned this issue Apr 15, 2020
Closed
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hsuanxyz
fix(module:badge): allow nzTitle set to null (NG-ZORRO#4965)
8eb9706 
close NG-ZORRO#4776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsuanxyz hsuanxyz

Labels
Component: Badge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(module:badge): allow nzTitle set to null hsuanxyz/ng-zorro-antd
2 participants
@krokofant @hsuanxyz