Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:skeleton): add nz-skeleton-element #4859

Merged
merged 8 commits into from Mar 12, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Mar 9, 2020

Close #4619

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 9, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #4859 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4859      +/-   ##
==========================================
+ Coverage   92.94%   92.94%   +<.01%     
==========================================
  Files         505      506       +1     
  Lines       12741    12750       +9     
  Branches     1972     1965       -7     
==========================================
+ Hits        11842    11851       +9     
  Misses        474      474              
  Partials      425      425
Impacted Files Coverage Δ
components/skeleton/skeleton.component.ts 100% <ø> (ø)
components/skeleton/skeleton-element.component.ts 100% <100%> (ø)
components/skeleton/skeleton.module.ts 100% <100%> (ø)
...omponents/date-picker/abstract-picker.component.ts 94.96% <0%> (-0.11%) ⬇️
components/cascader/cascader.component.ts 95.39% <0%> (ø) ⬆️
components/date-picker/date-picker.service.ts 100% <0%> (ø) ⬆️
components/tree-select/nz-tree-select.module.ts
components/tree-select/nz-tree-select.component.ts
components/tree-select/nz-tree-select.service.ts
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247ac85...fe5fbbe. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 8dc2ff3 into NG-ZORRO:master Mar 12, 2020
@wenqi73 wenqi73 deleted the refactor-skeleton branch March 12, 2020 11:26
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:skeleton): add nz-skeleton-element

* docs: optimize docs

* test: add tests

* chore: add docs label style

* refactor: use component as directive

* fix: tests

* docs: change en doc

* chore: change directive name
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:skeleton): add nz-skeleton-element

* docs: optimize docs

* test: add tests

* chore: add docs label style

* refactor: use component as directive

* fix: tests

* docs: change en doc

* chore: change directive name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Skeleton] support avatar & button & input properties
3 participants