Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:code-editor): upgrade monaco to 0.20.0 and update interfaces #4984

Merged
merged 1 commit into from Apr 7, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 5, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 5, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 5, 2020

Codecov Report

Merging #4984 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4984      +/-   ##
==========================================
- Coverage   91.48%   91.46%   -0.02%     
==========================================
  Files         538      538              
  Lines       13738    13738              
  Branches     2043     2043              
==========================================
- Hits        12568    12566       -2     
- Misses        707      708       +1     
- Partials      463      464       +1     
Impacted Files Coverage Δ
components/code-editor/typings.ts 71.42% <ø> (ø)
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6803a92...fee46d2. Read the comment docs.

@vthinkxie vthinkxie merged commit 3963ad1 into NG-ZORRO:master Apr 7, 2020
@wzhudev wzhudev deleted the editor-upgrade branch April 8, 2020 14:22
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
Ricbet added a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:tooltip,etc): support custom origin (NG-ZORRO#4849)

* chore: sync ant-design v4.1.1 (NG-ZORRO#4987)

Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>

* feat(module:code-editor): upgrade monaco to 0.20.0 and update interfaces (NG-ZORRO#4984)

* fix(module:badge): allow `nzTitle` set to null (NG-ZORRO#4965)

close NG-ZORRO#4776

* chore: add optional chaining and nullish coalescing (NG-ZORRO#4946)

* chore: add optional chaining and nullish coalescing

* test: fix tests

* test: fix tests

* feat(module:space): add new component (NG-ZORRO#4928)

close NG-ZORRO#4913

* feat: support compact theme (NG-ZORRO#4972)

Co-authored-by: Wendell <wendellhu95@gmail.com>
Co-authored-by: ng-zorro-bot <33472860+ng-zorro-bot@users.noreply.github.com>
Co-authored-by: ng-zorro-bot <ng-zorro-bot@users.noreply.github.com>
Co-authored-by: Hsuan Lee <HsuanGM@gmail.com>
Co-authored-by: Wenqi <1264578441@qq.com>
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants