Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:popover,steps): fix popover always show title placeholder & steps nzDescription property support TemplateRef #556

Merged
merged 2 commits into from
Nov 16, 2017
Merged

fix(module:popover,steps): fix popover always show title placeholder & steps nzDescription property support TemplateRef #556

merged 2 commits into from
Nov 16, 2017

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 9, 2017 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #555 #523

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.318% when pulling 08833d5 on cipchk:master into 35112e8 on NG-ZORRO:master.

@cipchk cipchk changed the title fix(module:popover): fix always show title placeholder fix(module:popover,steps): fix popover always show title placeholder & steps nzDescription property support TemplateRef Nov 11, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.287% when pulling 76578b9 on cipchk:master into 35112e8 on NG-ZORRO:master.

wilsoncook
wilsoncook reviewed Nov 12, 2017
View reviewed changes
src/components/steps/nz-step.component.ts Outdated
<div class="ant-steps-title" [innerHTML]="nzTitle"></div>
<div class="ant-steps-description">
<ng-template #defaultDescriptionContent>{{_description}}</ng-template>
<ng-template [ngTemplateOutlet]="_descriptionTpl || defaultDescriptionContent"></ng-template>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should

<ng-container *ngIf="_description; else _descriptionTpl">{{ _description }}</ng-container>

more clear?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.287% when pulling 826c675 on cipchk:master into 35112e8 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.287% when pulling 826c675 on cipchk:master into 35112e8 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 4a4e393 into NG-ZORRO:master Nov 16, 2017
@julin69
Copy link

julin69 commented Dec 27, 2018

But i still dont know how to foreach the steps with nzDescription use TemplateRef,my code like this:

image

hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@cipchk @vthinkxie
fix(module:popover,steps): fix popover always show title placeholder …
00dc5c0 
…& steps nzDescription property support TemplateRef (NG-ZORRO#556)

* fix(module:popover): fix always show title placeholder

* feat(module:steps): nzDescription property support TemplateRef

close NG-ZORRO#555 close NG-ZORRO#523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsoncook wilsoncook wilsoncook left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cipchk @coveralls @julin69 @wilsoncook @vthinkxie