Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nzTree手动添加兄弟节点功能 #5739

Closed
lzc199507 opened this issue Sep 3, 2020 · 0 comments · Fixed by #6161
Closed

nzTree手动添加兄弟节点功能 #5739

lzc199507 opened this issue Sep 3, 2020 · 0 comments · Fixed by #6161
Assignees
@simplejason
Labels
Component: Tree
Milestone
backlog

Comments

@lzc199507
Copy link

What problem does this feature solve?

目前NzTreeNode方法中添加节点的方法只有addChildren, 而使用此方法的前提是，有个Node，即为添加后的node的ParentNode。

现在有个需求，如nzData = [ NzTreeNode1, NzTreeNode2 ] ，要手动添加一个newNode，跟1和2平级的，这个时候因为是最外层，NzTreeNode1 或 NzTreeNode2 的 ParentNode 是 null，所以无法使用addChildren方式添加， 只能通过 nzData = [ ...nzData, newNode ]，可是通过修改nzData，会触发treeComponent的ngOnChanges，触发renderTreeProperties进而触发handleNzData，进而导致nzTreeService触发initTree方法，使得之前保存的expanded状态、halfChecked状态、checked状态等，全部丢失。

因此有这个需求，当父节点不存在时，需要有可以添加兄弟节点的方法。

What does the proposed API look like?

类似dom的nextSibling或previousSibling

const node = nzTree.getTreeNodeByKey('key')或其他方式
获取某个node
通过node.addNextSiblingNode(newNode)
@hsuanxyz hsuanxyz added this to the backlog milestone Oct 23, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
5ed97f7 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
@hsuanxyz hsuanxyz mentioned this issue Dec 8, 2020
Merged
3 tasks
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
51fa956 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
c98aff6 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
c7d8d2d 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
87bd33c 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
6b91a21 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 8, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
13a550d 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 9, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
171a7bb 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 14, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
7bc5156 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this issue Dec 16, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component
3afe868 
close NG-ZORRO#5976, close NG-ZORRO#5809, close NG-ZORRO#5739, close NG-ZORRO#5736, close NG-ZORRO#5519, close NG-ZORRO#5446, close NG-ZORRO#5152, close NG-ZORRO#4694, close NG-ZORRO#4472, close NG-ZORRO#3832, close NG-ZORRO#2785, close NG-ZORRO#2744
hsuanxyz added a commit that referenced this issue Dec 16, 2020
@hsuanxyz
feat(module:tree-view): add tree-view component (#6161)
05d58de 
close #5976, close #5809, close #5739, close #5736, close #5519, close #5446, close #5152, close #4694, close #4472, close #3832, close #2785, close #2744, close #6199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simplejason simplejason

Labels
Component: Tree
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

feat(module:tree-view): add tree-view component hsuanxyz/ng-zorro-antd
3 participants
@simplejason @hsuanxyz @lzc199507