Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nz-autocomplete.component.ts #1384

Closed
wants to merge 1 commit into from
Closed

Conversation

elvisqi
Copy link

@elvisqi elvisqi commented May 1, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

显示出多余的空行

image

image

Issue Number: N/A

What is the new behavior?

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

显示出多余的空行
@elvisqi elvisqi closed this May 1, 2018
@elvisqi elvisqi reopened this May 1, 2018
@codecov
Copy link

codecov bot commented May 1, 2018

Codecov Report

Merging #1384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1384   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         196      196           
  Lines        8339     8339           
  Branches     1102     1102           
=======================================
  Hits         8092     8092           
  Misses         31       31           
  Partials      216      216
Impacted Files Coverage Δ
...ponents/auto-complete/nz-autocomplete.component.ts 96.59% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ae3c1...da7f1a4. Read the comment docs.

@vthinkxie vthinkxie requested a review from hsuanxyz May 1, 2018 15:09
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elvisqi 感谢你的PR,这里可以将整个 :host 选择器删除。

@vthinkxie vthinkxie closed this in 5ad0452 May 9, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants