Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:transfer): fix TransferItem type to work with strictNullChecks #1589

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

dmytroyarmak
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1588

What is the new behavior?

An application can be successfully compiled with enabled "strictNullChecks".

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 3, 2018

Codecov Report

Merging #1589 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1589   +/-   ##
======================================
  Coverage      96%     96%           
======================================
  Files         466     466           
  Lines       10954   10954           
  Branches     1448    1448           
======================================
  Hits        10516   10516           
  Misses        123     123           
  Partials      315     315

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c33d0...09b6c87. Read the comment docs.

@vthinkxie vthinkxie merged commit 7601af1 into NG-ZORRO:master Jun 4, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants