Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:rate): add tooltip support #2794

Merged
merged 1 commit into from Feb 11, 2019
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jan 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #2794 into master will decrease coverage by 0.01%.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2794      +/-   ##
==========================================
- Coverage   95.52%   95.51%   -0.02%     
==========================================
  Files         517      517              
  Lines       12258    12231      -27     
  Branches     1691     1689       -2     
==========================================
- Hits        11710    11682      -28     
- Misses        189      190       +1     
  Partials      359      359
Impacted Files Coverage Δ
components/core/util/public-api.ts 100% <ø> (ø) ⬆️
components/icon/nz-icon.service.ts 98.27% <ø> (ø) ⬆️
components/rate/nz-rate.module.ts 100% <100%> (ø) ⬆️
components/rate/nz-rate-item.component.ts 91.66% <91.66%> (ø)
components/rate/nz-rate.component.ts 98.14% <98.07%> (-0.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2000fa...5adb7c7. Read the comment docs.

@wzhudev wzhudev changed the title refactor(module:rate): refactor rate feat(module:rate): add tooltip support Jan 16, 2019
@netlify
Copy link

netlify bot commented Jan 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit ae4f502

https://deploy-preview-2794--ng-zorro-master.netlify.com

@netlify
Copy link

netlify bot commented Jan 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 5adb7c7

https://deploy-preview-2794--ng-zorro-master.netlify.com

@wzhudev wzhudev added this to In progress in Roadmap 2019 via automation Jan 28, 2019
@wzhudev wzhudev added this to the Angular 7.0 milestone Jan 28, 2019
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit e121bd3 into NG-ZORRO:master Feb 11, 2019
Roadmap 2019 automation moved this from In progress to Done Feb 11, 2019
@wzhudev wzhudev deleted the fix-rate branch February 18, 2019 01:12
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Roadmap 2019
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants